extensions api: windows.removeWindow(), events: onWindowCreated, onWindowRemoved

Implement removeWindow, onWindowCreated, onWindowRemoved.

BUG=11200
R=aa

Committed: http://src.chromium.org/viewvc/14924

[rafaelw, 2009-04-29 18:32:14]

My first git-tastic CL. yeah!

[Aaron Boodman, 2009-04-29 20:32:02]

http://codereview.chromium.org/100164/diff/1/3
File chrome/browser/extensions/extension_browser_event_router.h (right):

http://codereview.chromium.org/100164/diff/1/3#newcode49
Line 49: void BrowserClosed(Browser* browser);
Comments?

http://codereview.chromium.org/100164/diff/1/5
File chrome/browser/extensions/extension_tabs_module.cc (right):

http://codereview.chromium.org/100164/diff/1/5#newcode73
Line 73: // Only examine browsers in the current profile
Nit: add a period to this sentence.

http://codereview.chromium.org/100164/diff/1/5#newcode153
Line 153: // Look for optional url.
Looks like a paste-o.

http://codereview.chromium.org/100164/diff/1/5#newcode154
Line 154: if (!args_->IsType(Value::TYPE_INTEGER))
Should be using Erik's VALIDATE_EXTENSION_FUNCTION or whatever it's called
macro. Not sure if you were planning to go through and do that all in a second
pass or what.

http://codereview.chromium.org/100164/diff/1/5#newcode164
Line 164: // Only examine browsers in the current profile
Nit: .

http://codereview.chromium.org/100164/diff/1/5#newcode174
Line 174: return false;
TODO(rafaelw): error message.

http://codereview.chromium.org/100164/diff/1/8
File chrome/renderer/resources/extension_process_bindings.js (right):

http://codereview.chromium.org/100164/diff/1/8#newcode94
Line 94: 
Extra space here.

http://codereview.chromium.org/100164/diff/1/8#newcode237
Line 237: 
Extra space here.

[rafaelw, 2009-04-29 20:58:56]

http://codereview.chromium.org/100164/diff/1/3
File chrome/browser/extensions/extension_browser_event_router.h (right):

http://codereview.chromium.org/100164/diff/1/3#newcode49
Line 49: void BrowserClosed(Browser* browser);
On 2009/04/29 20:32:03, Aaron Boodman wrote:
> Comments?

Done.

http://codereview.chromium.org/100164/diff/1/5
File chrome/browser/extensions/extension_tabs_module.cc (right):

http://codereview.chromium.org/100164/diff/1/5#newcode73
Line 73: // Only examine browsers in the current profile
On 2009/04/29 20:32:03, Aaron Boodman wrote:
> Nit: add a period to this sentence.

Done.

http://codereview.chromium.org/100164/diff/1/5#newcode153
Line 153: // Look for optional url.
On 2009/04/29 20:32:03, Aaron Boodman wrote:
> Looks like a paste-o.

Done.

http://codereview.chromium.org/100164/diff/1/5#newcode154
Line 154: if (!args_->IsType(Value::TYPE_INTEGER))
On 2009/04/29 20:32:03, Aaron Boodman wrote:
> Should be using Erik's VALIDATE_EXTENSION_FUNCTION or whatever it's called
> macro. Not sure if you were planning to go through and do that all in a second
> pass or what.

Yeah, I need to a do a cleanup pass on the existing tab methods, so I'll do
those two things together.

http://codereview.chromium.org/100164/diff/1/5#newcode164
Line 164: // Only examine browsers in the current profile
On 2009/04/29 20:32:03, Aaron Boodman wrote:
> Nit: .

Done.

http://codereview.chromium.org/100164/diff/1/5#newcode174
Line 174: return false;
On 2009/04/29 20:32:03, Aaron Boodman wrote:
> TODO(rafaelw): error message.

Done.

http://codereview.chromium.org/100164/diff/1/8
File chrome/renderer/resources/extension_process_bindings.js (right):

http://codereview.chromium.org/100164/diff/1/8#newcode94
Line 94: 
On 2009/04/29 20:32:03, Aaron Boodman wrote:
> Extra space here.

Done.

http://codereview.chromium.org/100164/diff/1/8#newcode237
Line 237: 
On 2009/04/29 20:32:03, Aaron Boodman wrote:
> Extra space here.

Done.

[Aaron Boodman, 2009-04-29 21:00:14]

LGTM