Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5811)

Unified Diff: chrome/renderer/resources/extension_process_bindings.js

Issue 100164: extensions api: windows.removeWindow(), events: onWindowCreated, onWindowRemoved (Closed)
Patch Set: touch grd to avoid clobber build Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/renderer_resources.grd ('k') | chrome/test/data/extensions/samples/tabs/tabs_api.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extension_process_bindings.js
diff --git a/chrome/renderer/resources/extension_process_bindings.js b/chrome/renderer/resources/extension_process_bindings.js
index 1abb06fc20a5a30408834d40ff09f78a6cc42916..199f4366351784885bbfbba0933dbebc5e8b2cb3 100644
--- a/chrome/renderer/resources/extension_process_bindings.js
+++ b/chrome/renderer/resources/extension_process_bindings.js
@@ -11,6 +11,7 @@ var chromium;
(function() {
native function GetNextCallbackId();
native function CreateWindow();
+ native function RemoveWindow();
native function GetWindows();
native function GetTabsForWindow();
native function GetTab();
@@ -90,15 +91,15 @@ var chromium;
//----------------------------------------------------------------------------
- // Tabs
- chromium.tabs = {};
+ // Windows
+ chromium.windows = {};
- chromium.tabs.getWindows = function(windowQuery, callback) {
+ chromium.windows.getWindows = function(windowQuery, callback) {
validate(arguments, arguments.callee.params);
sendRequest(GetWindows, windowQuery, callback);
};
- chromium.tabs.getWindows.params = [
+ chromium.windows.getWindows.params = [
{
type: "object",
properties: {
@@ -113,11 +114,11 @@ var chromium;
chromium.types.optFun
];
- chromium.tabs.createWindow = function(createData, callback) {
+ chromium.windows.createWindow = function(createData, callback) {
validate(arguments, arguments.callee.params);
sendRequest(CreateWindow, createData, callback);
};
- chromium.tabs.createWindow.params = [
+ chromium.windows.createWindow.params = [
{
type: "object",
properties: {
@@ -131,6 +132,31 @@ var chromium;
},
chromium.types.optFun
];
+
+ chromium.windows.removeWindow = function(windowId, callback) {
+ validate(arguments, arguments.callee.params);
+ sendRequest(RemoveWindow, windowId, callback);
+ };
+
+ chromium.windows.removeWindow.params = [
+ chromium.types.pInt,
+ chromium.types.optFun
+ ];
+
+ // sends (windowId).
+ // *WILL* be followed by tab-attached AND then tab-selection-changed.
+ chromium.windows.onWindowCreated = new chromium.Event("window-created");
+
+ // sends (windowId).
+ // *WILL* be preceded by sequences of tab-removed AND then
+ // tab-selection-changed -- one for each tab that was contained in the window
+ // that closed
+ chromium.windows.onWindowRemoved = new chromium.Event("window-removed");
+
+ //----------------------------------------------------------------------------
+
+ // Tabs
+ chromium.tabs = {};
// TODO(aa): This should eventually take an optional windowId param.
chromium.tabs.getTabsForWindow = function(callback) {
« no previous file with comments | « chrome/renderer/renderer_resources.grd ('k') | chrome/test/data/extensions/samples/tabs/tabs_api.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698