Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8920)

Unified Diff: chrome/test/data/extensions/samples/tabs/tabs_api.html

Issue 100164: extensions api: windows.removeWindow(), events: onWindowCreated, onWindowRemoved (Closed)
Patch Set: touch grd to avoid clobber build Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/resources/extension_process_bindings.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/samples/tabs/tabs_api.html
diff --git a/chrome/test/data/extensions/samples/tabs/tabs_api.html b/chrome/test/data/extensions/samples/tabs/tabs_api.html
index a506fd28f559543d928c470800fd3c2fa8c34c70..022d1a7eaede1b3fd3867eb1f697d72e17daf865 100644
--- a/chrome/test/data/extensions/samples/tabs/tabs_api.html
+++ b/chrome/test/data/extensions/samples/tabs/tabs_api.html
@@ -7,7 +7,7 @@ tabs = {};
tabIds = [];
function loadWindowList() {
- chromium.tabs.getWindows(undefined, function(windowList) {
+ chromium.windows.getWindows(undefined, function(windowList) {
tabs = {};
tabIds = [];
for (var i = 0; i < windowList.length; i++) {
@@ -84,6 +84,16 @@ function clearLog() {
document.getElementById('log').innerHTML = '';
}
+chromium.windows.onWindowCreated.addListener(function(windowId) {
+ appendToLog('onWindowCreated -- window: ' + windowId);
+ loadWindowList();
+});
+
+chromium.windows.onWindowRemoved.addListener(function(windowId) {
+ appendToLog('onWindowRemoved -- window: ' + windowId);
+ loadWindowList();
+});
+
chromium.tabs.onTabCreated.addListener(function(data) {
appendToLog('onTabCreated -- window: ' + data.windowId + ' tab: ' + data.tabId + ' index ' + data.index);
loadWindowList();
@@ -109,8 +119,8 @@ chromium.tabs.onTabSelectionChanged.addListener(function(data) {
loadWindowList();
});
-chromium.tabs.onTabRemoved.addListener(function(data) {
- appendToLog('onTabRemoved -- window: ' + data.windowId + ' tab: ' + data.tabId + ' index ' + data.index);
+chromium.tabs.onTabRemoved.addListener(function(tabId) {
+ appendToLog('onTabRemoved -- tab: ' + tabId);
loadWindowList();
});
@@ -138,7 +148,7 @@ function createWindow() {
if (!args.url)
delete args.url;
- chromium.tabs.createWindow(args);
+ chromium.windows.createWindow(args);
}
</script>
@@ -181,6 +191,7 @@ function createWindow() {
<button onclick="chromium.tabs.removeTab(this.jstdata);" jsvalues=".jstdata:id">Close Tab</button>
</div>
</div>
+ <button onclick="chromium.windows.removeWindow(this.jstdata);" jsvalues=".jstdata:id">Close Window</button>
</div>
</div>
<div style="background-color: #EEEEBB; margin: 20px; padding: 8px">
@@ -228,7 +239,7 @@ function createWindow() {
<button onclick="updateAll();">Update All</button>
<button onclick="moveAll();">Move All</button>
<button onclick="clearLog();">-->Clear Log</button>
- <button onclick="chromium.tabs.createWindow();">New Window</button>
+ <button onclick="chromium.windows.createWindow();">New Window</button>
</div>
<div id="log" style="background-color: #EEAAEE; margin: 20px; padding: 8px">
</div>
« no previous file with comments | « chrome/renderer/resources/extension_process_bindings.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698