RefCounted types should not have public destructors, ipc/ edition

RefCounted types should not have public destructors, ipc/ edition

BUG=123295
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134421

[Ryan Sleevi, 2012-04-13 09:47:46]

jam: PTAL

[jam, 2012-04-13 18:16:41]

lgtm

http://codereview.chromium.org/10008108/diff/2001/ipc/ipc_channel_proxy.cc
File ipc/ipc_channel_proxy.cc (right):

http://codereview.chromium.org/10008108/diff/2001/ipc/ipc_channel_proxy.cc#ne...
ipc/ipc_channel_proxy.cc:19: class SendCallbackHelper
oh, looks like we don't even need this class anymore, but can use the
base::Passed goodness. you don't need to do it here, but if you, that'd be
awesome

[Ryan Sleevi, 2012-04-25 06:14:15]

Hopefully this is suitably awesome.

Sending it to you one more time to make sure you're ok with the scoped_ptr<>
signature change, as it makes it easier to reason about the base::Passed<>
semantics.

[jam, 2012-04-25 15:02:32]

slgtm, thanks for the cleanup

[commit-bot: I haz the power, 2012-04-25 15:04:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10008108/10001

[commit-bot: I haz the power, 2012-04-25 15:15:41]

Try job failure for 10008108-10001 (retry) on android for steps "Compile,
build".
It's a second try, previously, steps "Compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

[commit-bot: I haz the power, 2012-04-26 03:22:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10008108/21001

[commit-bot: I haz the power, 2012-04-26 03:42:46]

Try job failure for 10008108-21001 (retry) on mac_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-04-27 01:39:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10008108/21001

[commit-bot: I haz the power, 2012-04-27 01:58:41]

Try job failure for 10008108-21001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-04-27 23:52:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10008108/45001

[commit-bot: I haz the power, 2012-04-28 02:12:03]

Change committed as 134421