Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: ipc/ipc_sync_message_filter.h

Issue 10008108: RefCounted types should not have public destructors, ipc/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Really fix Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ipc/ipc_sync_channel_unittest.cc ('k') | ipc/ipc_sync_message_filter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IPC_IPC_SYNC_MESSAGE_FILTER_H_ 5 #ifndef IPC_IPC_SYNC_MESSAGE_FILTER_H_
6 #define IPC_IPC_SYNC_MESSAGE_FILTER_H_ 6 #define IPC_IPC_SYNC_MESSAGE_FILTER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <set> 9 #include <set>
10 10
(...skipping 12 matching lines...) Expand all
23 23
24 // This MessageFilter allows sending synchronous IPC messages from a thread 24 // This MessageFilter allows sending synchronous IPC messages from a thread
25 // other than the listener thread associated with the SyncChannel. It does not 25 // other than the listener thread associated with the SyncChannel. It does not
26 // support fancy features that SyncChannel does, such as handling recursion or 26 // support fancy features that SyncChannel does, such as handling recursion or
27 // receiving messages while waiting for a response. Note that this object can 27 // receiving messages while waiting for a response. Note that this object can
28 // be used to send simultaneous synchronous messages from different threads. 28 // be used to send simultaneous synchronous messages from different threads.
29 class IPC_EXPORT SyncMessageFilter : public ChannelProxy::MessageFilter, 29 class IPC_EXPORT SyncMessageFilter : public ChannelProxy::MessageFilter,
30 public Message::Sender { 30 public Message::Sender {
31 public: 31 public:
32 explicit SyncMessageFilter(base::WaitableEvent* shutdown_event); 32 explicit SyncMessageFilter(base::WaitableEvent* shutdown_event);
33 virtual ~SyncMessageFilter();
34 33
35 // Message::Sender implementation. 34 // Message::Sender implementation.
36 virtual bool Send(Message* message) OVERRIDE; 35 virtual bool Send(Message* message) OVERRIDE;
37 36
38 // ChannelProxy::MessageFilter implementation. 37 // ChannelProxy::MessageFilter implementation.
39 virtual void OnFilterAdded(Channel* channel) OVERRIDE; 38 virtual void OnFilterAdded(Channel* channel) OVERRIDE;
40 virtual void OnChannelError() OVERRIDE; 39 virtual void OnChannelError() OVERRIDE;
41 virtual void OnChannelClosing() OVERRIDE; 40 virtual void OnChannelClosing() OVERRIDE;
42 virtual bool OnMessageReceived(const Message& message) OVERRIDE; 41 virtual bool OnMessageReceived(const Message& message) OVERRIDE;
43 42
43 protected:
44 virtual ~SyncMessageFilter();
45
44 private: 46 private:
45 void SendOnIOThread(Message* message); 47 void SendOnIOThread(Message* message);
46 // Signal all the pending sends as done, used in an error condition. 48 // Signal all the pending sends as done, used in an error condition.
47 void SignalAllEvents(); 49 void SignalAllEvents();
48 50
49 // The channel to which this filter was added. 51 // The channel to which this filter was added.
50 Channel* channel_; 52 Channel* channel_;
51 53
52 // The process's main thread. 54 // The process's main thread.
53 scoped_refptr<base::MessageLoopProxy> listener_loop_; 55 scoped_refptr<base::MessageLoopProxy> listener_loop_;
54 56
55 // The message loop where the Channel lives. 57 // The message loop where the Channel lives.
56 scoped_refptr<base::MessageLoopProxy> io_loop_; 58 scoped_refptr<base::MessageLoopProxy> io_loop_;
57 59
58 typedef std::set<PendingSyncMsg*> PendingSyncMessages; 60 typedef std::set<PendingSyncMsg*> PendingSyncMessages;
59 PendingSyncMessages pending_sync_messages_; 61 PendingSyncMessages pending_sync_messages_;
60 62
61 // Locks data members above. 63 // Locks data members above.
62 base::Lock lock_; 64 base::Lock lock_;
63 65
64 base::WaitableEvent* shutdown_event_; 66 base::WaitableEvent* shutdown_event_;
65 67
66 DISALLOW_COPY_AND_ASSIGN(SyncMessageFilter); 68 DISALLOW_COPY_AND_ASSIGN(SyncMessageFilter);
67 }; 69 };
68 70
69 } // namespace IPC 71 } // namespace IPC
70 72
71 #endif // IPC_IPC_SYNC_MESSAGE_FILTER_H_ 73 #endif // IPC_IPC_SYNC_MESSAGE_FILTER_H_
OLDNEW
« no previous file with comments | « ipc/ipc_sync_channel_unittest.cc ('k') | ipc/ipc_sync_message_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698