RefCounted types should not have public destructors, ipc/ edition

ipc/ipc_channel_proxy.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/debug/trace_event.h"
 #include "base/location.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "ipc/ipc_channel_proxy.h"
 #include "ipc/ipc_logging.h"
 #include "ipc/ipc_message_utils.h"
 
 namespace IPC {
 
 // This helper ensures the message is deleted if the task is deleted without
 // having been run.
 class SendCallbackHelper

[jam, 2012/04/13 18:16:41]

oh, looks like we don't even need this class anymore, but can use the
base::Passed goodness. you don't need to do it here, but if you, that'd be
awesome

     : public base::RefCountedThreadSafe<SendCallbackHelper> {
  public:
   SendCallbackHelper(ChannelProxy::Context* context, Message* message)
       : context_(context),
         message_(message) {
   }
 
   void Send() {
     context_->OnSendMessage(message_.release());
   }
 
  private:
+  friend class base::RefCountedThreadSafe<SendCallbackHelper>;
+  ~SendCallbackHelper() {}
+
   scoped_refptr<ChannelProxy::Context> context_;
   scoped_ptr<Message> message_;
 
   DISALLOW_COPY_AND_ASSIGN(SendCallbackHelper);
 };
 
 //------------------------------------------------------------------------------
 
 ChannelProxy::MessageFilter::MessageFilter() {}
 
@@ skipping 366 matching lines @@
   Channel* channel = context_.get()->channel_.get();
   // Channel must have been created first.
   DCHECK(channel) << context_.get()->channel_id_;
   return channel->GetClientEuid(client_euid);
 }
 #endif
 
 //-----------------------------------------------------------------------------
 
 }  // namespace IPC