Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 10006047: Persist the alternate protocol as a string not an int to allow the enum to be changed without affec… (Closed)

Created:
8 years, 8 months ago by Ryan Hamilton
Modified:
8 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Persist the alternate protocol as a string not an int to allow the enum to be changed without affecting persisted values. BUG=121967 TEST=HttpServerPropertiesManagerTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131601

Patch Set 1 #

Patch Set 2 : Minor cleanup #

Total comments: 1

Patch Set 3 : Fix raman's comments. #

Patch Set 4 : Rebase #

Patch Set 5 : Add NET_EXPORT to new public functions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -13 lines) Patch
M chrome/browser/net/http_server_properties_manager.cc View 1 3 chunks +14 lines, -8 lines 0 comments Download
M chrome/browser/net/http_server_properties_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_server_properties.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M net/http/http_server_properties.cc View 1 2 3 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ryan Hamilton
8 years, 8 months ago (2012-04-06 21:15:58 UTC) #1
ramant (doing other things)
http://codereview.chromium.org/10006047/diff/1005/net/http/http_server_properties.cc File net/http/http_server_properties.cc (right): http://codereview.chromium.org/10006047/diff/1005/net/http/http_server_properties.cc#newcode39 net/http/http_server_properties.cc:39: for (int i = NPN_SPDY_1; i < NPN_SPDY_3; i++) ...
8 years, 8 months ago (2012-04-07 00:41:22 UTC) #2
Ryan Hamilton
On 2012/04/07 00:41:22, ramant wrote: > http://codereview.chromium.org/10006047/diff/1005/net/http/http_server_properties.cc > File net/http/http_server_properties.cc (right): > > http://codereview.chromium.org/10006047/diff/1005/net/http/http_server_properties.cc#newcode39 > ...
8 years, 8 months ago (2012-04-09 16:37:20 UTC) #3
ramant (doing other things)
lgtm
8 years, 8 months ago (2012-04-09 16:50:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/10006047/5001
8 years, 8 months ago (2012-04-09 18:18:36 UTC) #5
commit-bot: I haz the power
Try job failure for 10006047-5001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-09 19:24:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/10006047/14001
8 years, 8 months ago (2012-04-09 20:52:39 UTC) #7
commit-bot: I haz the power
Try job failure for 10006047-14001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-09 21:56:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/10006047/16001
8 years, 8 months ago (2012-04-10 16:52:03 UTC) #9
commit-bot: I haz the power
8 years, 8 months ago (2012-04-10 19:11:40 UTC) #10
Change committed as 131601

Powered by Google App Engine
This is Rietveld 408576698