Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Side by Side Diff: net/http/http_server_properties.cc

Issue 10006047: Persist the alternate protocol as a string not an int to allow the enum to be changed without affec… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add NET_EXPORT to new public functions Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/http/http_server_properties.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_server_properties.h" 5 #include "net/http/http_server_properties.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/stringprintf.h" 8 #include "base/stringprintf.h"
9 9
10 namespace net { 10 namespace net {
11 11
12 const char kAlternateProtocolHeader[] = "Alternate-Protocol"; 12 const char kAlternateProtocolHeader[] = "Alternate-Protocol";
13 const char* const kAlternateProtocolStrings[] = { 13 const char* const kAlternateProtocolStrings[] = {
14 "npn-spdy/1", 14 "npn-spdy/1",
15 "npn-spdy/2", 15 "npn-spdy/2",
16 "npn-spdy/3", 16 "npn-spdy/3",
17 }; 17 };
18 const char kBrokenAlternateProtocol[] = "Broken";
18 19
19 static const char* AlternateProtocolToString(AlternateProtocol protocol) { 20 const char* AlternateProtocolToString(AlternateProtocol protocol) {
20 switch (protocol) { 21 switch (protocol) {
21 case NPN_SPDY_1: 22 case NPN_SPDY_1:
22 case NPN_SPDY_2: 23 case NPN_SPDY_2:
23 case NPN_SPDY_3: 24 case NPN_SPDY_3:
24 return kAlternateProtocolStrings[protocol]; 25 return kAlternateProtocolStrings[protocol];
25 case ALTERNATE_PROTOCOL_BROKEN: 26 case ALTERNATE_PROTOCOL_BROKEN:
26 return "Broken"; 27 return kBrokenAlternateProtocol;
27 case UNINITIALIZED_ALTERNATE_PROTOCOL: 28 case UNINITIALIZED_ALTERNATE_PROTOCOL:
28 return "Uninitialized"; 29 return "Uninitialized";
29 default: 30 default:
30 NOTREACHED(); 31 NOTREACHED();
31 return ""; 32 return "";
32 } 33 }
33 } 34 }
34 35
36 AlternateProtocol AlternateProtocolFromString(const std::string& protocol) {
37 for (int i = NPN_SPDY_1; i < NUM_ALTERNATE_PROTOCOLS; ++i)
38 if (protocol == kAlternateProtocolStrings[i])
39 return static_cast<AlternateProtocol>(i);
40 if (protocol == kBrokenAlternateProtocol)
41 return ALTERNATE_PROTOCOL_BROKEN;
42 return UNINITIALIZED_ALTERNATE_PROTOCOL;
43 }
44
45
35 std::string PortAlternateProtocolPair::ToString() const { 46 std::string PortAlternateProtocolPair::ToString() const {
36 return base::StringPrintf("%d:%s", port, 47 return base::StringPrintf("%d:%s", port,
37 AlternateProtocolToString(protocol)); 48 AlternateProtocolToString(protocol));
38 } 49 }
39 50
40 } // namespace net 51 } // namespace net
OLDNEW
« no previous file with comments | « net/http/http_server_properties.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698