Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1452)

Unified Diff: chrome/browser/net/http_server_properties_manager_unittest.cc

Issue 10006047: Persist the alternate protocol as a string not an int to allow the enum to be changed without affec… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add NET_EXPORT to new public functions Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/http_server_properties_manager.cc ('k') | net/http/http_server_properties.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/http_server_properties_manager_unittest.cc
diff --git a/chrome/browser/net/http_server_properties_manager_unittest.cc b/chrome/browser/net/http_server_properties_manager_unittest.cc
index 6602b3b90c6a3ca0828044caa2e5374f45b0fc11..a8f77b1d8fd3fc6fe687924d6876fb1a94d7004c 100644
--- a/chrome/browser/net/http_server_properties_manager_unittest.cc
+++ b/chrome/browser/net/http_server_properties_manager_unittest.cc
@@ -142,7 +142,7 @@ TEST_F(HttpServerPropertiesManagerTest,
// Set up alternate_protocol for www.google.com:80.
base::DictionaryValue* alternate_protocol = new base::DictionaryValue;
alternate_protocol->SetInteger("port", 443);
- alternate_protocol->SetInteger("protocol", static_cast<int>(net::NPN_SPDY_1));
+ alternate_protocol->SetString("protocol_str", "npn-spdy/1");
server_pref_dict->SetWithoutPathExpansion(
"alternate_protocol", alternate_protocol);
@@ -164,8 +164,8 @@ TEST_F(HttpServerPropertiesManagerTest,
// Set up alternate_protocol for mail.google.com:80
base::DictionaryValue* alternate_protocol1 = new base::DictionaryValue;
alternate_protocol1->SetInteger("port", 444);
- alternate_protocol1->SetInteger(
- "protocol", static_cast<int>(net::NPN_SPDY_2));
+ alternate_protocol1->SetString("protocol_str", "npn-spdy/2");
+
server_pref_dict1->SetWithoutPathExpansion(
"alternate_protocol", alternate_protocol1);
« no previous file with comments | « chrome/browser/net/http_server_properties_manager.cc ('k') | net/http/http_server_properties.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698