Added Undo close window to menu. Standardized capitalization for ...

Final tweaks based on review from pkasting.

BUG=11183

[Miranda Callahan, 2009-04-29 16:19:34]

Fixed code so that it actually modifies the label when the menu is created.

[Peter Kasting, 2009-04-29 16:34:48]

Basically LGTM, just a lot of small things.

http://codereview.chromium.org/100054/diff/17/1018
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/100054/diff/17/1018#newcode575
Line 575: Undo close tab
Do we want these wording changes?  I liked the old wording significantly better
("Reopen closed xxx").

Also, your new menu items have no accelerators.

http://codereview.chromium.org/100054/diff/17/1018#newcode577
Line 577: <message name="IDS_RESTORE_WINDOW" desc="The text label of the Restore
Window menu item" >
Nit: No space before trailing '>'.  Please also fix the couple entries above
while you're here.

http://codereview.chromium.org/100054/diff/17/1019
File chrome/browser/views/frame/browser_view.cc (right):

http://codereview.chromium.org/100054/diff/17/1019#newcode478
Line 478: if (browser_->profile()->GetTabRestoreService() &&
Nit: Pull out "browser_->profile()->GetTabRestoreService()" into a temp for
clarity.

http://codereview.chromium.org/100054/diff/17/1019#newcode480
Line 480: if (browser_->profile()->GetTabRestoreService()->
Nit: Would be shorter and IMO clearer to just do:

system_menu_->ModifyMenuLabel(command,
    l10n_util::GetString(tab_restore_service->entries().front()->type ==
    TabRestoreService::WINDOW ? IDS_RESTORE_WINDOW : IDS_RESTORE_TAB));

http://codereview.chromium.org/100054/diff/17/1019#newcode1249
Line 1249: void BrowserView::InitSystemMenu() {
Nit: Don't add trailing whitespace here (I thought presubmit checks should have
caught this...)

http://codereview.chromium.org/100054/diff/17/1016
File chrome/views/controls/menu/menu.cc (right):

http://codereview.chromium.org/100054/diff/17/1016#newcode454
Line 454: MENUITEMINFO mii;
Nit: I suggest " = { 0 };" for clarity on this (and the other instances in the
file).  I never remember whether stack structures are auto-initialized, and
whether they need to be before calling Windows functions, so this makes
everything obvious and safe.

http://codereview.chromium.org/100054/diff/17/1017
File chrome/views/controls/menu/menu.h (right):

http://codereview.chromium.org/100054/diff/17/1017#newcode272
Line 272: void ModifyMenuLabel(int item_id, const std::wstring& label);
Nit: Do you think SetMenuItemLabel() would be clearer?

[Miranda Callahan, 2009-04-29 20:13:06]

Peter, thanks for the review!  I incorporated all changes except the wording
change -- there was a long thread in the previous issue report discussing the
word choice, and consensus seemed to finally form around "Undo ..."

[Miranda Callahan, 2009-04-29 20:33:14]

Changed text to "Reopen closed..." based on verbal instruction from Glen and
Peter.  Thanks!

[Peter Kasting, 2009-04-29 20:37:35]

LGTM with nits

http://codereview.chromium.org/100054/diff/1040/1044
File chrome/browser/views/frame/browser_view.cc (right):

http://codereview.chromium.org/100054/diff/1040/1044#newcode482
Line 482: l10n_util::GetString(tab_restore_service->
Nit: indent in 4 spaces here, not 2.

For the rest of this statement, feel free to wrap things at the indent point
instead of even with the open paren if it results in easier-to-read long lines. 
e.g. you could break after "GetString(" and "==" maybe.

http://codereview.chromium.org/100054/diff/1040/1044#newcode487
Line 487: enabled = false;
Nit: Indent in 2 spaces here, not 4.

[Miranda Callahan, 2009-04-29 21:17:39]

Indenting corrected -- thanks!

[Peter Kasting, 2009-04-29 23:09:22]

Committed as r14910.