Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9382027: Move client/{base, observable, layout, touch, util, view} to samples/ui_lib . (Closed)

Created:
8 years, 10 months ago by dgrove
Modified:
8 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move client/{base, observable, layout, touch, util, view} to samples/ui_lib . Committed: https://code.google.com/p/dart/source/detail?r=4154

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1690 lines, -9368 lines) Patch
D client/base/AnimationScheduler.dart View 1 chunk +0 lines, -166 lines 0 comments Download
D client/base/Device.dart View 1 chunk +0 lines, -82 lines 0 comments Download
D client/base/DomWrapper.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D client/base/Env.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D client/base/Size.dart View 1 chunk +0 lines, -138 lines 0 comments Download
D client/base/base.dart View 1 chunk +0 lines, -14 lines 0 comments Download
D client/layout/GridLayout.dart View 1 chunk +0 lines, -520 lines 0 comments Download
D client/layout/GridLayoutParams.dart View 1 chunk +0 lines, -107 lines 0 comments Download
D client/layout/GridLayoutParser.dart View 1 chunk +0 lines, -486 lines 0 comments Download
D client/layout/GridTracks.dart View 1 chunk +0 lines, -187 lines 0 comments Download
D client/layout/SizingFunctions.dart View 1 chunk +0 lines, -149 lines 0 comments Download
D client/layout/ViewLayout.dart View 1 chunk +0 lines, -237 lines 0 comments Download
D client/layout/layout.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D client/observable/ChangeEvent.dart View 1 chunk +0 lines, -84 lines 0 comments Download
D client/observable/EventBatch.dart View 1 chunk +0 lines, -104 lines 0 comments Download
D client/observable/observable.dart View 1 chunk +0 lines, -299 lines 0 comments Download
M client/tests/client/client.status View 3 chunks +0 lines, -6 lines 0 comments Download
M client/tests/client/html/html_tests.dart View 1 chunk +0 lines, -2 lines 0 comments Download
D client/tests/client/layout/CSS.dart View 1 chunk +0 lines, -348 lines 0 comments Download
D client/tests/client/layout/GridExamples.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D client/tests/client/layout/GridLayoutDemo.dart View 1 chunk +0 lines, -132 lines 0 comments Download
D client/tests/client/layout/grid_layout_demo.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D client/tests/client/layout/grid_layout_demo.html View 1 chunk +0 lines, -11 lines 0 comments Download
D client/tests/client/layout/layout.css View 1 chunk +0 lines, -18 lines 0 comments Download
D client/tests/client/layout/layout.scss View 1 chunk +0 lines, -316 lines 0 comments Download
D client/tests/client/layout/layout_tests.dart View 1 chunk +0 lines, -188 lines 0 comments Download
D client/tests/client/observable/AbstractObservableTests.dart View 1 chunk +0 lines, -73 lines 0 comments Download
D client/tests/client/observable/ChangeEventTests.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D client/tests/client/observable/EventBatchTests.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D client/tests/client/observable/ObservableListTests.dart View 1 chunk +0 lines, -118 lines 0 comments Download
D client/tests/client/observable/ObservableValueTests.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D client/tests/client/observable/observable_tests.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D client/tests/client/touch/touch_tests.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D client/tests/client/util/util_tests.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D client/tests/client/view/view_tests.dart View 1 chunk +0 lines, -203 lines 0 comments Download
D client/touch/BezierPhysics.dart View 1 chunk +0 lines, -114 lines 0 comments Download
D client/touch/ClickBuster.dart View 1 chunk +0 lines, -215 lines 0 comments Download
D client/touch/EventUtil.dart View 1 chunk +0 lines, -39 lines 0 comments Download
D client/touch/FxUtil.dart View 1 chunk +0 lines, -103 lines 0 comments Download
D client/touch/Geometry.dart View 1 chunk +0 lines, -91 lines 0 comments Download
D client/touch/InfiniteScroller.dart View 1 chunk +0 lines, -145 lines 0 comments Download
D client/touch/Math.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D client/touch/Momentum.dart View 1 chunk +0 lines, -554 lines 0 comments Download
D client/touch/ScrollWatcher.dart View 1 chunk +0 lines, -63 lines 0 comments Download
D client/touch/Scrollbar.dart View 1 chunk +0 lines, -352 lines 0 comments Download
D client/touch/Scroller.dart View 1 chunk +0 lines, -731 lines 0 comments Download
D client/touch/TimeUtil.dart View 1 chunk +0 lines, -14 lines 0 comments Download
D client/touch/TouchHandler.dart View 1 chunk +0 lines, -393 lines 0 comments Download
D client/touch/TouchUtil.dart View 1 chunk +0 lines, -242 lines 0 comments Download
D client/touch/resources/touch.css View 1 chunk +0 lines, -27 lines 0 comments Download
D client/touch/touch.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D client/util/CollectionUtils.dart View 1 chunk +0 lines, -139 lines 0 comments Download
D client/util/DateUtils.dart View 1 chunk +0 lines, -185 lines 0 comments Download
D client/util/StringUtils.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D client/util/Uri.dart View 1 chunk +0 lines, -77 lines 0 comments Download
D client/util/utilslib.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D client/view/CompositeView.dart View 1 chunk +0 lines, -87 lines 0 comments Download
D client/view/ConveyorView.dart View 1 chunk +0 lines, -98 lines 0 comments Download
D client/view/MeasureText.dart View 1 chunk +0 lines, -161 lines 0 comments Download
D client/view/PagedViews.dart View 1 chunk +0 lines, -287 lines 0 comments Download
D client/view/SliderMenu.dart View 1 chunk +0 lines, -176 lines 0 comments Download
D client/view/resources/view.css View 1 chunk +0 lines, -174 lines 0 comments Download
D client/view/view.dart View 1 chunk +0 lines, -371 lines 0 comments Download
M samples/isolate_html/IsolateSample.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/isolate_html/isolate_sample.dart View 1 chunk +0 lines, -1 line 0 comments Download
M samples/slider/SliderSample.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/slider/slider_sample.dart View 1 chunk +1 line, -2 lines 0 comments Download
M samples/slider/slider_sample.html View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/swarmlib.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M samples/tests/samples/samples.status View 1 2 chunks +7 lines, -0 lines 0 comments Download
A samples/tests/samples/src/lib/layout/CSS.dart View 1 chunk +348 lines, -0 lines 0 comments Download
A samples/tests/samples/src/lib/layout/GridExamples.dart View 1 chunk +32 lines, -0 lines 0 comments Download
A samples/tests/samples/src/lib/layout/GridLayoutDemo.dart View 1 chunk +132 lines, -0 lines 0 comments Download
A samples/tests/samples/src/lib/layout/LayoutTest.dart View 1 chunk +188 lines, -0 lines 0 comments Download
A samples/tests/samples/src/lib/layout/grid_layout_demo.dart View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A samples/tests/samples/src/lib/layout/grid_layout_demo.html View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
A samples/tests/samples/src/lib/layout/layout.css View 1 chunk +18 lines, -0 lines 0 comments Download
A samples/tests/samples/src/lib/layout/layout.scss View 1 chunk +316 lines, -0 lines 0 comments Download
A samples/tests/samples/src/lib/observable/AbstractObservableTests.dart View 1 chunk +73 lines, -0 lines 0 comments Download
A samples/tests/samples/src/lib/observable/ChangeEventTests.dart View 1 chunk +30 lines, -0 lines 0 comments Download
A samples/tests/samples/src/lib/observable/EventBatchTests.dart View 1 chunk +38 lines, -0 lines 0 comments Download
A samples/tests/samples/src/lib/observable/ObservableListTests.dart View 1 chunk +118 lines, -0 lines 0 comments Download
A samples/tests/samples/src/lib/observable/ObservableTest.dart View 1 chunk +48 lines, -0 lines 0 comments Download
A samples/tests/samples/src/lib/observable/ObservableValueTests.dart View 1 chunk +42 lines, -0 lines 0 comments Download
A samples/tests/samples/src/lib/touch/TouchTest.dart View 1 chunk +50 lines, -0 lines 0 comments Download
A + samples/tests/samples/src/lib/util/UtilTest.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D samples/tests/samples/src/lib/util/util_tests.dart View 1 chunk +0 lines, -43 lines 0 comments Download
A samples/tests/samples/src/lib/view/ViewTest.dart View 1 chunk +203 lines, -0 lines 0 comments Download
M samples/tests/samples/src/swarm/SwarmTest.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M + samples/ui_lib/util/utilslib.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dgrove
8 years, 10 months ago (2012-02-10 23:11:09 UTC) #1
Siggi Cherem (dart-lang)
lgtm http://codereview.chromium.org/9382027/diff/1091/samples/tests/samples/src/lib/layout/grid_layout_demo.dart File samples/tests/samples/src/lib/layout/grid_layout_demo.dart (right): http://codereview.chromium.org/9382027/diff/1091/samples/tests/samples/src/lib/layout/grid_layout_demo.dart#newcode19 samples/tests/samples/src/lib/layout/grid_layout_demo.dart:19: Dom.ready(_onLoad); here too? http://codereview.chromium.org/9382027/diff/1091/samples/tests/samples/src/lib/layout/grid_layout_demo.html File samples/tests/samples/src/lib/layout/grid_layout_demo.html (right): http://codereview.chromium.org/9382027/diff/1091/samples/tests/samples/src/lib/layout/grid_layout_demo.html#newcode9 ...
8 years, 10 months ago (2012-02-10 23:24:50 UTC) #2
dgrove
http://codereview.chromium.org/9382027/diff/1091/samples/tests/samples/src/lib/layout/grid_layout_demo.dart File samples/tests/samples/src/lib/layout/grid_layout_demo.dart (right): http://codereview.chromium.org/9382027/diff/1091/samples/tests/samples/src/lib/layout/grid_layout_demo.dart#newcode19 samples/tests/samples/src/lib/layout/grid_layout_demo.dart:19: Dom.ready(_onLoad); On 2012/02/10 23:24:50, sigmund wrote: > here too? ...
8 years, 10 months ago (2012-02-10 23:35:58 UTC) #3
Siggi Cherem (dart-lang)
8 years, 10 months ago (2012-02-10 23:43:00 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698