Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 9150006: test.dart: Stop looping over vmOptions in browser tests to turn the buildbot green. (Closed)

Created:
8 years, 11 months ago by Bill Hesse
Modified:
8 years, 11 months ago
Reviewers:
ricow1, Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

test.dart: Stop looping over vmOptions in browser tests to turn the buildbot green. There are some flaky tests in the language suite in component chromium with the dart test script. They all have multiple vmOptions lines, so temporarily disabling that functionality to turn the build green again. BUG= TEST=tools/test.dart -cchromium language Committed: https://code.google.com/p/dart/source/detail?r=3110

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M tools/testing/dart/test_suite.dart View 1 chunk +4 lines, -1 line 2 comments Download

Messages

Total messages: 4 (0 generated)
Bill Hesse
TBR=efortuna@google.com, ricow@google.com This is just temporary until tomorrow. I'll file a bug.
8 years, 11 months ago (2012-01-09 18:55:26 UTC) #1
Bill Hesse
On 2012/01/09 18:55:26, Bill Hesse wrote: > mailto:TBR=efortuna@google.com, mailto:ricow@google.com > > This is just temporary ...
8 years, 11 months ago (2012-01-09 19:03:32 UTC) #2
Emily Fortuna
http://codereview.chromium.org/9150006/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): http://codereview.chromium.org/9150006/diff/1/tools/testing/dart/test_suite.dart#newcode367 tools/testing/dart/test_suite.dart:367: var vmOptions = optionsFromFile['vmOptions'][0]; { I think what may ...
8 years, 11 months ago (2012-01-09 19:08:36 UTC) #3
Emily Fortuna
8 years, 11 months ago (2012-01-09 19:10:14 UTC) #4
http://codereview.chromium.org/9150006/diff/1/tools/testing/dart/test_suite.dart
File tools/testing/dart/test_suite.dart (right):

http://codereview.chromium.org/9150006/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:367: var vmOptions =
optionsFromFile['vmOptions'][0]; {
Fixing url from above: http://code.google.com/p/dart/issues/detail?id=1046

This is just a guess, but somehow multiple --flags items do not seem to be
combined correctly.

On 2012/01/09 19:08:36, Emily Fortuna wrote:
> I think what may be happening is if you specify --flags= multiple times, which
> is probably what the buildbot is doing, it only uses the last --flags value
> instead of combining them. For example, in my dart command listed here:
>
http://code.google.com/p/dart/issues/detail?id=1046&can=4&colspec=ID%2520Type...,
> this opens chrome as the test browser, even though I specified "ff." The
problem
> goes away if I combine all of the --flag options into one flag that is comma
> separated. I didn't complain about this because I thought this was your
intended
> behavior?

Powered by Google App Engine
This is Rietveld 408576698