test.dart: Stop looping over vmOptions in browser tests to turn the buildbot green.

tools/testing/dart/test_suite.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library("test_suite");
 
 #import("status_file_parser.dart");
 #import("test_runner.dart");
 #import("multitest.dart");
 
@@ skipping 344 matching lines @@
     if (!testPath.startsWith(dartDir) ||
         dartDir.endsWith('/frog')) {
       dartDir = new File('..').fullPathSync();
       if (!testPath.startsWith(dartDir)) {
         print('Run test.dart from the dart directory or' +
               ' an immediate subdirectory only.');
         Expect.fail('Could not find top level dart directory.');
       }
     }
 
-    for (var vmOptions in optionsFromFile['vmOptions']) {
+    // TODO(whesse): Find out if this loop is turning the buildbot red.
+    // for (var vmOptions in optionsFromFile['vmOptions']) {
+    var vmOptions = optionsFromFile['vmOptions'][0]; {

[Emily Fortuna, 2012/01/09 19:08:36]

I think what may be happening is if you specify --flags= multiple times, which
is probably what the buildbot is doing, it only uses the last --flags value
instead of combining them. For example, in my dart command listed here:
http://code.google.com/p/dart/issues/detail?id=1046&can=4&colspec=ID%20Type%2...,
this opens chrome as the test browser, even though I specified "ff." The problem
goes away if I combine all of the --flag options into one flag that is comma
separated. I didn't complain about this because I thought this was your intended
behavior? 

[Emily Fortuna, 2012/01/09 19:10:16]

Fixing url from above: http://code.google.com/p/dart/issues/detail?id=1046

This is just a guess, but somehow multiple --flags items do not seem to be
combined correctly.

On 2012/01/09 19:08:36, Emily Fortuna wrote:

+
       // Create a unique temporary directory for each set of vmOptions.
       // TODO(whesse): Replace separate replaces with a RegExp when
       // replaceAll(RegExp, String) is implemented.
       String optionsName = '';
       if (optionsFromFile['vmOptions'].length > 1) {
           optionsName = Strings.join(vmOptions, '-').replaceAll('-','')
                                                     .replaceAll('=','')
                                                     .replaceAll('/','');
       }
       Directory tempDir =
@@ skipping 650 matching lines @@
  * $noCrash tests are expected to be flaky but not crash
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout\
 """;
     print(report);
   }
 }