test.dart: Stop looping over vmOptions in browser tests to turn the buildbot green.

tools/testing/dart/test_suite.dart

Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index f865d0c8bb714848169d3a82ea400d4633c5399b..c545b63713bf04b8276214822a41f0b4dbe1aaa6 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -362,7 +362,10 @@ class StandardTestSuite implements TestSuite {
       }
     }
 
-    for (var vmOptions in optionsFromFile['vmOptions']) {
+    // TODO(whesse): Find out if this loop is turning the buildbot red.
+    // for (var vmOptions in optionsFromFile['vmOptions']) {
+    var vmOptions = optionsFromFile['vmOptions'][0]; {

[Emily Fortuna, 2012/01/09 19:08:36]

I think what may be happening is if you specify --flags= multiple times, which
is probably what the buildbot is doing, it only uses the last --flags value
instead of combining them. For example, in my dart command listed here:
http://code.google.com/p/dart/issues/detail?id=1046&can=4&colspec=ID%20Type%2...,
this opens chrome as the test browser, even though I specified "ff." The problem
goes away if I combine all of the --flag options into one flag that is comma
separated. I didn't complain about this because I thought this was your intended
behavior? 

[Emily Fortuna, 2012/01/09 19:10:16]

Fixing url from above: http://code.google.com/p/dart/issues/detail?id=1046

This is just a guess, but somehow multiple --flags items do not seem to be
combined correctly.

On 2012/01/09 19:08:36, Emily Fortuna wrote:

+
       // Create a unique temporary directory for each set of vmOptions.
       // TODO(whesse): Replace separate replaces with a RegExp when
       // replaceAll(RegExp, String) is implemented.