Issue 9113017: Add unitAboutToCompile() into DartCompilerListener

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9113017: Add unitAboutToCompile() into DartCompilerListener (Closed)

Created:
8 years, 11 months ago by scheglov

Modified:
8 years, 11 months ago

Reviewers:
codefu, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add unitAboutToCompile() into DartCompilerListener R=brianwilkerson@google.com,codefu@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3045

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+118 lines, -170 lines)			Patch
M	compiler/java/com/google/dart/compiler/DartCompilerListener.java	View	1 chunk	+35 lines, -11 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/DartCompilerMainContext.java	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/DefaultDartCompilerListener.java	View	3 chunks	+17 lines, -13 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/DeltaAnalyzer.java	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartUnit.java	View	2 chunks	+3 lines, -8 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartScannerParserContext.java	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/ParserContext.java	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/testing/TestCompilerContext.java	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/CompilerTestCase.java	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/DartCompilerListenerTest.java	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/backend/common/TypeHeuristicImplementationTest.java	View	2 chunks	+1 line, -10 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/common/LibrarySourceFileTest.java	View	3 chunks	+1 line, -5 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/DartParserRunner.java	View	3 chunks	+6 lines, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerBench.java	View	2 chunks	+1 line, -10 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeTestCase.java	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	compiler/javatests/com/google/dart/corelib/SharedTestCase.java	View	3 chunks	+1 line, -6 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/AST.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/CompilerListener.java	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/compiler/LoggingDartCompilerListener.java	View	2 chunks	+2 lines, -12 lines	0 comments	Download
D	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/compiler/SilentDartCompilerListener.java	View	1 chunk	+0 lines, -37 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/formatter/CodeSnippetParsingUtil.java	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/compiler/TestCompilerListener.java	View	2 chunks	+4 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mmendez

On 2012/01/05 18:46:45, scheglov wrote: Lets hold off on this change until we've had a ...

8 years, 11 months ago (2012-01-05 18:56:44 UTC) #2

Brian Wilkerson

LGTM, pending resolution of the question of whether this is the approach we want to ...

8 years, 11 months ago (2012-01-05 21:17:47 UTC) #3

lgtm

Expand Messages | Collapse Messages