editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java - Issue 9113017: Add unitAboutToCompile() into DartCompilerListener

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java

Issue 9113017: Add unitAboutToCompile() into DartCompilerListener (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/compiler/SilentDartCompilerListener.java ('k') | editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/formatter/CodeSnippetParsingUtil.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java

diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java

index 6aea02f55672951512af7e5a00680d526a73ad92..e7414f6ef6c0e83449ebc8830b42da1d211bca27 100644

--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java

+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java

@@ -70,7 +70,6 @@ import com.google.dart.tools.core.completion.CompletionMetrics;

import com.google.dart.tools.core.completion.CompletionProposal;

import com.google.dart.tools.core.completion.CompletionRequestor;

import com.google.dart.tools.core.dom.NodeFinder;

-import com.google.dart.tools.core.internal.compiler.SilentDartCompilerListener;

import com.google.dart.tools.core.internal.completion.ScopedNameFinder.ScopedName;

import com.google.dart.tools.core.internal.completion.ast.BlockCompleter;

import com.google.dart.tools.core.internal.completion.ast.FunctionCompleter;

@@ -1046,7 +1045,7 @@ public class CompletionEngine {

&& source.charAt(actualCompletionPosition) == '.';

CompletionMetrics metrics = requestor.getMetrics();

- DartCompilerListener listener = SilentDartCompilerListener.INSTANCE;

+ DartCompilerListener listener = DartCompilerListener.EMPTY;

ParserContext ctx = new DartScannerParserContext(sourceFile, source, listener);

CompletionParser parser = new CompletionParser(ctx);

parser.setCompletionPosition(completionPosition);

@@ -1087,8 +1086,7 @@ public class CompletionEngine {

return;

}

Scope unitScope = resolvedUnit.getLibrary().getElement().getScope();

- typeProvider = new CoreTypeProviderImplementation(unitScope,

- SilentDartCompilerListener.INSTANCE);

+ typeProvider = new CoreTypeProviderImplementation(unitScope, DartCompilerListener.EMPTY);

classElement = null;

if (resolvedMember != null) {