Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/compiler/LoggingDartCompilerListener.java

Issue 9113017: Add unitAboutToCompile() into DartCompilerListener (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/compiler/LoggingDartCompilerListener.java
diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/compiler/LoggingDartCompilerListener.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/compiler/LoggingDartCompilerListener.java
index b230fb756e9d91dfc6f8f6cd1de0d0e193eeb041..135085abed48b3236cc53df6ff0386ffd0bd3503 100644
--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/compiler/LoggingDartCompilerListener.java
+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/compiler/LoggingDartCompilerListener.java
@@ -17,18 +17,16 @@ import com.google.dart.compiler.DartCompilationError;
import com.google.dart.compiler.DartCompilerListener;
import com.google.dart.compiler.ErrorSeverity;
import com.google.dart.compiler.SubSystem;
-import com.google.dart.compiler.ast.DartUnit;
import com.google.dart.tools.core.DartCore;
/**
- * Log compilation errors for debugging purposes
+ * Log compilation errors for debugging purposes.
*/
-public class LoggingDartCompilerListener extends DartCompilerListener {
+public class LoggingDartCompilerListener extends DartCompilerListener.Empty {
/**
* A compiler listener that can be shared.
*/
public static final LoggingDartCompilerListener INSTANCE = new LoggingDartCompilerListener();
-
private boolean ignoreWarnings;
public LoggingDartCompilerListener() {
@@ -44,21 +42,13 @@ public class LoggingDartCompilerListener extends DartCompilerListener {
if (event.getErrorCode().getErrorSeverity() == ErrorSeverity.ERROR) {
DartCore.logError("Compilation error: " + event);
}
-
if (event.getErrorCode().getErrorSeverity() == ErrorSeverity.WARNING) {
if (!ignoreWarnings) {
DartCore.logError("Compilation warning: " + event);
}
}
-
if (event.getErrorCode().getSubSystem() == SubSystem.STATIC_TYPE) {
DartCore.logError("Type error: " + event);
}
}
-
- @Override
- public void unitCompiled(DartUnit unit) {
-
- }
-
}

Powered by Google App Engine
This is Rietveld 408576698