Implement revised factories in the VM.

Implement revised factories in the VM.
Emit warnings when obsolete syntax is used.
Committed: https://code.google.com/p/dart/source/detail?r=2394

[srdjan, 2011-12-13 19:27:05]

LGTM with questions/comments.

Could you check in all places in Dart code if mention of issue 417 should be
removed (see comments in hash_map_set.dart)?
Do you have a test that checks for failure if type arguments in interface and
factory do not match?

http://codereview.chromium.org/8921033/diff/4001/corelib/src/implementation/h...
File corelib/src/implementation/hash_map_set.dart (right):

http://codereview.chromium.org/8921033/diff/4001/corelib/src/implementation/h...
corelib/src/implementation/hash_map_set.dart:53: // See issue 417. Works in the
vm, fails in dartc and frog.
This is not 417 anymore, isn't it?

http://codereview.chromium.org/8921033/diff/4001/corelib/src/implementation/h...
corelib/src/implementation/hash_map_set.dart:278: // See issue 417. Works in the
vm, fails in dartc and frog.
ditto

[regis, 2011-12-13 19:34:57]

Thanks!

I cannot yet remove mentions of issue 417 in the code, since frog and dartc need
to implement the new syntax.

There will be another change where core lib is modified to the final syntax as
shown in the updated comments of this cl.

I will add a test in a later cl, since building and testing both frog and dartc
is very painful. I'll submit what I have working now.

Thanks,
Regis

http://codereview.chromium.org/8921033/diff/4001/corelib/src/implementation/h...
File corelib/src/implementation/hash_map_set.dart (right):

http://codereview.chromium.org/8921033/diff/4001/corelib/src/implementation/h...
corelib/src/implementation/hash_map_set.dart:53: // See issue 417. Works in the
vm, fails in dartc and frog.
On 2011/12/13 19:27:05, srdjan wrote:
> This is not 417 anymore, isn't it?

Well, it is still the same ongoing issue (factory syntax and type parameters).
It makes little sense to create a new issue.

http://codereview.chromium.org/8921033/diff/4001/corelib/src/implementation/h...
corelib/src/implementation/hash_map_set.dart:278: // See issue 417. Works in the
vm, fails in dartc and frog.
On 2011/12/13 19:27:05, srdjan wrote:
> ditto

ditto