Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: corelib/src/implementation/hash_map_set.dart

Issue 8921033: Implement revised factories in the VM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | corelib/src/implementation/linked_hash_map.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: corelib/src/implementation/hash_map_set.dart
===================================================================
--- corelib/src/implementation/hash_map_set.dart (revision 2391)
+++ corelib/src/implementation/hash_map_set.dart (working copy)
@@ -51,7 +51,7 @@
}
// See issue 417. Works in the vm, fails in dartc and frog.
srdjan 2011/12/13 19:27:05 This is not 417 anymore, isn't it?
regis 2011/12/13 19:34:57 Well, it is still the same ongoing issue (factory
- factory HashMapImplementation/*<K, V>*/.from(Map/*<K, V>*/ other) {
+ factory HashMapImplementation.from(Map/*<K, V>*/ other) {
Map/*<K, V>*/ result = new HashMapImplementation/*<K, V>*/();
other.forEach((/*K*/ key, /*V*/ value) { result[key] = value; });
return result;
@@ -276,7 +276,7 @@
}
// See issue 417. Works in the vm, fails in dartc and frog.
srdjan 2011/12/13 19:27:05 ditto
regis 2011/12/13 19:34:57 ditto
- factory HashSetImplementation/*<E>*/.from(Iterable/*<E>*/ other) {
+ factory HashSetImplementation.from(Iterable/*<E>*/ other) {
Set/*<E>*/ set = new HashSetImplementation/*<E>*/();
for (final e in other) {
set.add(e);
« no previous file with comments | « no previous file | corelib/src/implementation/linked_hash_map.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698