Implement revised factories in the VM.

runtime/vm/class_finalizer.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/class_finalizer.h"
 
 #include "vm/flags.h"
 #include "vm/heap.h"
 #include "vm/isolate.h"
 #include "vm/longjump.h"
@@ skipping 709 matching lines @@
   return NULL;
 }
 
 
 void ClassFinalizer::ResolveAndFinalizeSignature(const Class& cls,
                                                  const Function& function) {
   // Resolve result type.
   AbstractType& type = AbstractType::Handle(function.result_type());
   if (!type.IsResolved()) {
     if (function.IsFactory()) {
-      // The signature class of the factory for a generic class holds the type
-      // parameters and their upper bounds. Copy the signature class from the
-      // result before it gets resolved.
+      // TODO(regis): Factory functions should not declare type parameters
+      // anymore. Remove this code once all libraries are fixed.
+
+      // The signature class of the factory for a generic class used to hold the
+      // type parameters and their upper bounds. Copy the signature class from
+      // the result before it gets resolved.
       const UnresolvedClass& unresolved_type_class =
           UnresolvedClass::Handle(type.unresolved_class());
       const Class& factory_signature_class =
           Class::Handle(unresolved_type_class.factory_signature_class());
-      ASSERT(!factory_signature_class.IsNull());
-      function.set_signature_class(factory_signature_class);
-      ResolveType(cls, type);
-      const Class& type_class = Class::Handle(type.type_class());
-      // Verify that the factory signature declares the same number of type
-      // parameters as the return type class or interface.
-      ResolveAndFinalizeUpperBounds(factory_signature_class);
-      if (factory_signature_class.NumTypeParameters() !=
-          type_class.NumTypeParameters()) {
-        const String& function_name = String::Handle(function.name());
-        if (factory_signature_class.NumTypeParameters() == 0) {
-          // TODO(regis): For now, and until the core lib is fixed, we accept a
-          // factory method with missing list of type parameters and use the
-          // list of the enclosing class.
-          // See bug 5408808.
-          const Class& enclosing_class = Class::Handle(function.owner());
-          function.set_signature_class(enclosing_class);
-          const Script& script = Script::Handle(enclosing_class.script());
-          ReportWarning(script, unresolved_type_class.token_index(),
-                        "factory method '%s' should declare a list of "
-                        "%d type parameter%s.\n",
-                        function_name.ToCString(),
-                        type_class.NumTypeParameters(),
-                        type_class.NumTypeParameters() > 1 ? "s" : "");
-        } else {
+
+      if (!factory_signature_class.IsNull()) {
+        // TODO(regis): Remove support for obsolete syntax in the parser.
+        ASSERT(factory_signature_class.NumTypeParameters() > 0);
+        function.set_signature_class(factory_signature_class);
+        ResolveType(cls, type);
+        const Class& type_class = Class::Handle(type.type_class());
+        // Verify that the factory signature declares the same number of type
+        // parameters as the return type class or interface.
+        ResolveAndFinalizeUpperBounds(factory_signature_class);
+        if (factory_signature_class.NumTypeParameters() !=
+            type_class.NumTypeParameters()) {
+          const String& function_name = String::Handle(function.name());
           const Class& enclosing_class = Class::Handle(function.owner());
           const Script& script = Script::Handle(enclosing_class.script());
           ReportError(script, unresolved_type_class.token_index(),
-                      "factory method '%s' must declare %d type parameter%s.\n",
-                      function_name.ToCString(),
-                      type_class.NumTypeParameters(),
-                      type_class.NumTypeParameters() > 1 ? "s" : "");
+                      "factory method '%s' declares wrong number of type "
+                      "parameters (obsolete syntax).\n",
+                      function_name.ToCString());
         }
+      } else {
+        ResolveType(cls, type);
       }
     } else {
       ResolveType(cls, type);
     }
   }
   type = FinalizeType(cls, type);
   function.set_result_type(type);
   // Resolve formal parameter types.
   const intptr_t num_parameters = function.NumberOfParameters();
   for (intptr_t i = 0; i < num_parameters; i++) {
@@ skipping 532 matching lines @@
   va_end(args);
   if (FLAG_warning_as_error) {
     Isolate::Current()->long_jump_base()->Jump(1, message_buffer);
     UNREACHABLE();
   } else {
     OS::Print(message_buffer);
   }
 }
 
 }  // namespace dart