Issue 8873044: Fix crash from issue 744: evaluate left first before deopt happens (strict comparison).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8873044: Fix crash from issue 744: evaluate left first before deopt happens (strict comparison). (Closed)

Created:
9 years ago by srdjan

Modified:
9 years ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Fix crash from issue 744: evaluate left first before deopt happens (strict comparison). Committed: https://code.google.com/p/dart/source/detail?r=2295

Patch Set 1 #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	vm/opt_code_generator_ia32.cc	View		1 chunk	+2 lines, -3 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm http://codereview.chromium.org/8873044/diff/1/vm/opt_code_generator_ia32.cc File vm/opt_code_generator_ia32.cc (right): http://codereview.chromium.org/8873044/diff/1/vm/opt_code_generator_ia32.cc#newcode1947 vm/opt_code_generator_ia32.cc:1947: // must be on stack when evaluating right. ...

9 years ago (2011-12-09 01:24:56 UTC) #3

srdjan

9 years ago (2011-12-09 01:30:25 UTC) #4

http://codereview.chromium.org/8873044/diff/1/vm/opt_code_generator_ia32.cc
File vm/opt_code_generator_ia32.cc (right):

http://codereview.chromium.org/8873044/diff/1/vm/opt_code_generator_ia32.cc#n...
vm/opt_code_generator_ia32.cc:1947: // must be on stack when evaluating right.
On 2011/12/09 01:24:56, asiva wrote:
> There seems to be other such cases in GenerateLogicalBinaryOp and
> VisitLoadTwo(non DEBUG case) did you check those too for the same error?

Will do and it will be part of the next CL.

Expand Messages | Collapse Messages