Fix crash from issue 744: evaluate left first before deopt happens (strict comparison).

vm/opt_code_generator_ia32.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/opt_code_generator.h"
 
 #include "vm/assembler_macros.h"
@@ skipping 1925 matching lines @@
   return true;
 }
 
 
 // IS, ISNOT are handled in class CodeGenerator.
 void OptimizingCodeGenerator::VisitComparisonNode(ComparisonNode* node) {
   if ((node->kind() == Token::kEQ_STRICT) ||
       (node->kind() == Token::kNE_STRICT)) {
     const Bool& bool_true = Bool::ZoneHandle(Bool::True());
     const Bool& bool_false = Bool::ZoneHandle(Bool::False());
+    // Note that evaluation of right may cause deoptimization, therefore left
+    // must be on stack when evaluating right.

[siva, 2011/12/09 01:24:56]

There seems to be other such cases in GenerateLogicalBinaryOp and
VisitLoadTwo(non DEBUG case) did you check those too for the same error?

[srdjan, 2011/12/09 01:30:25]

Will do and it will be part of the next CL.

     if (node->right()->IsLiteralNode()) {
       VisitLoadOne(node->left(), EAX);
       __ CompareObject(EAX, node->right()->AsLiteralNode()->literal());
-    } else if (node->left()->IsLiteralNode()) {
-      VisitLoadOne(node->right(), EAX);
-      __ CompareObject(EAX, node->left()->AsLiteralNode()->literal());
     } else {
       VisitLoadTwo(node->left(), node->right(), EAX, EDX);
       __ cmpl(EAX, EDX);
     }
     if (!CodeGenerator::IsResultNeeded(node)) {
       return;
     }
     Condition condition = node->kind() == Token::kEQ_STRICT ? EQUAL : NOT_EQUAL;
     if (NodeInfoHasLabels(node)) {
       GenerateConditionalJumps(*(node->info()), condition);
@@ skipping 633 matching lines @@
   if (IsResultNeeded(node)) {
     // The result is the input value.
     __ pushl(EAX);
   }
 }
 
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32