Fix crash from issue 744: evaluate left first before deopt happens (strict comparison).

vm/opt_code_generator_ia32.cc

Index: vm/opt_code_generator_ia32.cc
===================================================================
--- vm/opt_code_generator_ia32.cc	(revision 2292)
+++ vm/opt_code_generator_ia32.cc	(working copy)
@@ -1943,12 +1943,11 @@
       (node->kind() == Token::kNE_STRICT)) {
     const Bool& bool_true = Bool::ZoneHandle(Bool::True());
     const Bool& bool_false = Bool::ZoneHandle(Bool::False());
+    // Note that evaluation of right may cause deoptimization, therefore left
+    // must be on stack when evaluating right.

[siva, 2011/12/09 01:24:56]

There seems to be other such cases in GenerateLogicalBinaryOp and
VisitLoadTwo(non DEBUG case) did you check those too for the same error?

[srdjan, 2011/12/09 01:30:25]

Will do and it will be part of the next CL.

     if (node->right()->IsLiteralNode()) {
       VisitLoadOne(node->left(), EAX);
       __ CompareObject(EAX, node->right()->AsLiteralNode()->literal());
-    } else if (node->left()->IsLiteralNode()) {
-      VisitLoadOne(node->right(), EAX);
-      __ CompareObject(EAX, node->left()->AsLiteralNode()->literal());
     } else {
       VisitLoadTwo(node->left(), node->right(), EAX, EDX);
       __ cmpl(EAX, EDX);