Issue 8763001: Fix names with '$' to not conflict with operators or internal helpers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8763001: Fix names with '$' to not conflict with operators or internal helpers (Closed)

Created:
9 years ago by Jennifer Messerly

Modified:
9 years ago

Reviewers:
jimhug

CC:
reviews_dartlang.org, Jacob

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix names with '$' to not conflict with operators or internal helpers. Does two things: * In our Dart type system, we track special names with ":" instead of "$". So ":add" and "get:foobar" "set:foobar". In "jsname" we change this back to $ * in jsname, mangle $'s from Dart identifiers into $$. It's not perfect, but should avoid conflicts with our various helpers. http://code.google.com/p/dart/issues/detail?id=639 Committed: https://code.google.com/p/dart/source/detail?r=1948

Patch Set 1 #

Patch Set 2 : merged and fixed return type #

Patch Set 3 : merged again #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+336 lines, -303 lines)			Patch
M	client/html/scripts/html-diff.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	frog/corejs.dart	View	1	7 chunks	+10 lines, -9 lines	0 comments	Download
M	frog/element.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	frog/frogsh	View		44 chunks	+143 lines, -142 lines	0 comments	Download
M	frog/gen.dart	View	1 2	9 chunks	+13 lines, -11 lines	0 comments	Download
M	frog/lib/natives.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	frog/library.dart	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	frog/member.dart	View		12 chunks	+68 lines, -46 lines	0 comments	Download
M	frog/parser.dart	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	frog/scripts/token_info.py	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	frog/scripts/token_kind_gen.py	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	frog/token_kind.g.dart	View	1 2	1 chunk	+41 lines, -41 lines	0 comments	Download
M	frog/type.dart	View		5 chunks	+6 lines, -6 lines	0 comments	Download
M	frog/value.dart	View		3 chunks	+8 lines, -28 lines	0 comments	Download
M	frog/world.dart	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/language/src/NamingTest.dart	View		4 chunks	+32 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jimhug

9 years ago (2011-12-14 22:11:32 UTC) #2

LGTM

Nice change!  When I first wrote this code, I didn't realize that '$' was a
legal dart identifier.  Then when I learned that it was allowed I really wanted
to see it go away so I didn't fix this.  Finally, Jacob convinced me that they
were a good idea at least for the interim period to bring jquery folks over and
I'm happy that you've cleaned this up.

Expand Messages | Collapse Messages