client/html/scripts/html-diff.dart - Issue 8763001: Fix names with '$' to not conflict with operators or internal helpers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/html/scripts/html-diff.dart

Issue 8763001: Fix names with '$' to not conflict with operators or internal helpers (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merged again Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: client/html/scripts/html-diff.dart

diff --git a/client/html/scripts/html-diff.dart b/client/html/scripts/html-diff.dart

index f0f2751e8fa9acb5de28b618eb18b9e9ef869a0e..f4580922836d90a757950fa1309a067a7d4976e4 100644

--- a/client/html/scripts/html-diff.dart

+++ b/client/html/scripts/html-diff.dart

@@ -109,7 +109,7 @@ class HtmlDiff {

}

if (domType == null) return new Set();

if (htmlMember.definition == null) return new Set();

- if (htmlMember.name == 'get\$on') {

+ if (htmlMember.name == 'get:on') {

final members = _members(domType.members['addEventListener']);

members.addAll(_members(domType.members['dispatchEvent']));

members.addAll(_members(domType.members['removeEventListener']));

« no previous file with comments | « no previous file | frog/corejs.dart » ('j') | no next file with comments »