frog/element.dart - Issue 8763001: Fix names with '$' to not conflict with operators or internal helpers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: frog/element.dart

Issue 8763001: Fix names with '$' to not conflict with operators or internal helpers (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merged again Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: frog/element.dart

diff --git a/frog/element.dart b/frog/element.dart

index e3ec26d68f844bc46eab7ac859e058d935c1f83f..8efe2207d861bc0f4d98c26ab6a74f666d73bf78 100644

--- a/frog/element.dart

+++ b/frog/element.dart

@@ -18,7 +18,7 @@ class Element implements Hashable {

Element _enclosingElement;

Element(this.name, this._enclosingElement) {

- _jsname = name;

+ _jsname = world.toJsIdentifier(name);

}

// TODO - walk tree

« no previous file with comments | « frog/corejs.dart ('k') | frog/frogsh » ('j') | no next file with comments »