Fix a number of issues with the process handling

Fix a number of issues with the process handling

1. Ignore the signal SIGPIPE on Linux and Mac OS

When reading from or writing to a closed pipe the signal SIGPIPE
is raised. The default handling of this is to terminate the
program. When signal SIGPIPE is ignored the read and write
returns EPIPE.

2. Wrong return type for stdio getter

3. When there is an error on a socket mark it as closed

4. Mark the pipe used for process exit status as a one way pipe

5. Add tests to test stdin, stdout and stderr in Dart scripts

R=ager@google.com

BUG=dart:536, dart:454
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=1793

[Mads Ager (google), 2011-11-23 12:45:19]

lgtm

http://codereview.chromium.org/8662006/diff/4001/runtime/bin/eventhandler_lin...
File runtime/bin/eventhandler_linux.cc (right):

http://codereview.chromium.org/8662006/diff/4001/runtime/bin/eventhandler_lin...
runtime/bin/eventhandler_linux.cc:218: printf("Poll events:\n");
Do you want to add this debugging line in the macos version as well?

http://codereview.chromium.org/8662006/diff/4001/runtime/bin/platform.h
File runtime/bin/platform.h (right):

http://codereview.chromium.org/8662006/diff/4001/runtime/bin/platform.h#newco...
runtime/bin/platform.h:14: 
There is only one blank between methods in the rest of the file, remove one
here?

http://codereview.chromium.org/8662006/diff/4001/runtime/bin/platform_linux.cc
File runtime/bin/platform_linux.cc (right):

http://codereview.chromium.org/8662006/diff/4001/runtime/bin/platform_linux.c...
runtime/bin/platform_linux.cc:20: perror("Setting signal handler failed");
return false?

http://codereview.chromium.org/8662006/diff/4001/runtime/bin/platform_macos.cc
File runtime/bin/platform_macos.cc (right):

http://codereview.chromium.org/8662006/diff/4001/runtime/bin/platform_macos.c...
runtime/bin/platform_macos.cc:21: return false;
Yup!

http://codereview.chromium.org/8662006/diff/4001/runtime/bin/socket_linux.cc
File runtime/bin/socket_linux.cc (right):

http://codereview.chromium.org/8662006/diff/4001/runtime/bin/socket_linux.cc#...
runtime/bin/socket_linux.cc:70: intptr_t Socket::Write(intptr_t fd, const void*
buffer, intptr_t num_bytes) {
You changed intptr_t to int in the interface?

http://codereview.chromium.org/8662006/diff/4001/tests/standalone/src/Process...
File tests/standalone/src/ProcessTestUtil.dart (right):

http://codereview.chromium.org/8662006/diff/4001/tests/standalone/src/Process...
tests/standalone/src/ProcessTestUtil.dart:25: String getDartFileName() {
I think this code is in TestRunnerTest as well. Could you grep for Release_ia32
and see if we an have them all use this one?

[Søren Gjesse, 2011-11-23 14:50:18]

http://codereview.chromium.org/8662006/diff/4001/runtime/bin/eventhandler_lin...
File runtime/bin/eventhandler_linux.cc (right):

http://codereview.chromium.org/8662006/diff/4001/runtime/bin/eventhandler_lin...
runtime/bin/eventhandler_linux.cc:218: printf("Poll events:\n");
On 2011/11/23 12:45:19, Mads Ager wrote:
> Do you want to add this debugging line in the macos version as well?

Yes, to separate each return from poll.

http://codereview.chromium.org/8662006/diff/4001/runtime/bin/platform.h
File runtime/bin/platform.h (right):

http://codereview.chromium.org/8662006/diff/4001/runtime/bin/platform.h#newco...
runtime/bin/platform.h:14: 
On 2011/11/23 12:45:19, Mads Ager wrote:
> There is only one blank between methods in the rest of the file, remove one
> here?

Done.

http://codereview.chromium.org/8662006/diff/4001/runtime/bin/platform_linux.cc
File runtime/bin/platform_linux.cc (right):

http://codereview.chromium.org/8662006/diff/4001/runtime/bin/platform_linux.c...
runtime/bin/platform_linux.cc:20: perror("Setting signal handler failed");
On 2011/11/23 12:45:19, Mads Ager wrote:
> return false?

Absolutely.

http://codereview.chromium.org/8662006/diff/4001/runtime/bin/socket_linux.cc
File runtime/bin/socket_linux.cc (right):

http://codereview.chromium.org/8662006/diff/4001/runtime/bin/socket_linux.cc#...
runtime/bin/socket_linux.cc:70: intptr_t Socket::Write(intptr_t fd, const void*
buffer, intptr_t num_bytes) {
On 2011/11/23 12:45:19, Mads Ager wrote:
> You changed intptr_t to int in the interface?

Done.

http://codereview.chromium.org/8662006/diff/4001/tests/standalone/src/Process...
File tests/standalone/src/ProcessTestUtil.dart (right):

http://codereview.chromium.org/8662006/diff/4001/tests/standalone/src/Process...
tests/standalone/src/ProcessTestUtil.dart:25: String getDartFileName() {
On 2011/11/23 12:45:19, Mads Ager wrote:
> I think this code is in TestRunnerTest as well. Could you grep for
Release_ia32
> and see if we an have them all use this one?

Done.