Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: tests/standalone/src/TestRunnerTest.dart

Issue 8662006: Fix a number of issues with the process handling (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments from ager@ Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/src/ProcessTestUtil.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/src/TestRunnerTest.dart
diff --git a/tests/standalone/src/TestRunnerTest.dart b/tests/standalone/src/TestRunnerTest.dart
index 8e676acd369116f726f0a5dfa1c4445a4d080703..b7dc8ef5b645bafa8b3ef146459fa4fe2731b1e5 100644
--- a/tests/standalone/src/TestRunnerTest.dart
+++ b/tests/standalone/src/TestRunnerTest.dart
@@ -23,7 +23,7 @@ class TestController {
for (var line in output.stdout) print(line);
print("stderr: ");
for (var line in output.stderr) print(line);
-
+
print("Time: ${output.time}");
print("Exit code: ${output.exitCode}");
@@ -45,7 +45,7 @@ TestCase MakeTestCase(String testName, List<String> expectations) {
var timeout = 2;
return new TestCase(testName,
- getDartBinName(),
+ getDartFileName(),
<String>["--ignore-unrecognized-flags",
"--enable_type_checks",
test_path],
@@ -55,27 +55,6 @@ TestCase MakeTestCase(String testName, List<String> expectations) {
}
-String getDartBinName() {
- var os = new Platform().operatingSystem();
-
- var outDir = '';
- if (os == 'linux') {
- outDir = 'out';
- } else if (os == 'macos') {
- outDir = 'xcodebuild';
- }
-
- var names = ['$outDir/Debug_ia32/dart',
- '$outDir/Release_ia32/dart'];
-
- for (var name in names) {
- if (new File(name).existsSync()) {
- return name;
- }
- }
-}
-
-
void main() {
int timeout = 2;
new RunningProcess(MakeTestCase("PassTest", [PASS]), timeout).start();
« no previous file with comments | « tests/standalone/src/ProcessTestUtil.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698