Fix a number of issues with the process handling

runtime/bin/eventhandler_linux.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <errno.h>
 #include <poll.h>
 #include <pthread.h>
 #include <stdio.h>
 #include <string.h>
 #include <sys/time.h>
@@ skipping 197 matching lines @@
     printf("(and %08x) ", pollfd->revents & ~all_events);
   }
   printf("(available %d) ", FDUtils::AvailableBytes(pollfd->fd));
 
   printf("\n");
 }
 #endif
 
 intptr_t EventHandlerImplementation::GetPollEvents(struct pollfd* pollfd) {
 #ifdef DEBUG_POLL
+  printf("Poll events:\n");

[Mads Ager (google), 2011/11/23 12:45:19]

Do you want to add this debugging line in the macos version as well?

[Søren Gjesse, 2011/11/23 14:50:18]

Yes, to separate each return from poll.

   if (pollfd->fd != interrupt_fds_[0]) PrintEventMask(pollfd);
 #endif
   intptr_t event_mask = 0;
   SocketData* sd = GetSocketData(pollfd->fd);
   if (sd->IsListeningSocket()) {
     // For listening sockets the POLLIN event indicate that there are
     // connections ready for accept unless accompanied with one of the
     // other flags.
     if ((pollfd->revents & POLLIN) != 0) {
       if ((pollfd->revents & POLLHUP) != 0) event_mask |= (1 << kCloseEvent);
@@ skipping 31 matching lines @@
           if (bytesPeeked == 0) {
             event_mask = (1 << kCloseEvent);
             sd->MarkClosedRead();
           } else if (errno != EAGAIN) {
             fprintf(stderr, "Error recv: %s\n", strerror(errno));
           }
         }
       }
     }
 
-    // On pipes POLLHUP is reported without POLLIN.
+    // On pipes POLLHUP is reported without POLLIN when there is no
+    // more data to read.
     if (sd->IsPipe()) {
       if (((pollfd->revents & POLLIN) == 0) &&
           ((pollfd->revents & POLLHUP) != 0)) {
         event_mask = (1 << kCloseEvent);
         sd->MarkClosedRead();
       }
     }
 
-    if ((pollfd->revents & POLLOUT) != 0) event_mask |= (1 << kOutEvent);
+    if ((pollfd->revents & POLLOUT) != 0) {
+      if ((pollfd->revents & POLLERR) != 0) {
+        event_mask = (1 << kErrorEvent);
+        sd->MarkClosedWrite();
+      } else {
+        event_mask |= (1 << kOutEvent);
+      }
+    }
   }
 
   return event_mask;
 }
 
 
 void EventHandlerImplementation::HandleEvents(struct pollfd* pollfds,
                                               int pollfds_size,
                                               int result_size) {
   if ((pollfds[0].revents & POLLIN) != 0) {
@@ skipping 72 matching lines @@
     FATAL("Create start event handler thread");
   }
 }
 
 
 void EventHandlerImplementation::SendData(intptr_t id,
                                           Dart_Port dart_port,
                                           intptr_t data) {
   WakeupHandler(id, dart_port, data);
 }