Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 8648003: Fix bug 557: Disallow user side allocation of ImmutableArray. Also added "instantiation-checks" f... (Closed)

Created:
9 years, 1 month ago by srdjan
Modified:
9 years, 1 month ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix bug 557: Disallow user side allocation of ImmutableArray. Also added "instantiation-checks" for some other VM-internal classes. Committed: https://code.google.com/p/dart/source/detail?r=1811

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -2 lines) Patch
M runtime/lib/array.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/lib/bool.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/lib/growable_array.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/lib/immutable_map.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/integers.dart View 1 4 chunks +16 lines, -0 lines 0 comments Download
M runtime/lib/string.dart View 1 7 chunks +35 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
srdjan
9 years, 1 month ago (2011-11-22 21:46:15 UTC) #1
hausner
9 years, 1 month ago (2011-11-23 19:26:19 UTC) #2
Looks all good to me.

Powered by Google App Engine
This is Rietveld 408576698