Fix bug 557: Disallow user side allocation of ImmutableArray. Also added "instantiation-checks" f...

runtime/lib/string.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * [StringBase] contains common methods used by concrete String implementations,
  * e.g., OneByteString.
  */
 class StringBase {
 
+  factory StringBase._uninstantiable() {
+    throw const UnsupportedOperationException(
+        "StringBase can't be instaniated");
+  }
+
   int hashCode() native "String_hashCode";
 
   /**
    *  Create the most efficient string representation for specified
    *  [codePoints].
    */
   static String createFromCharCodes(List<int> charCodes) {
     ObjectArray objectArray;
     if (charCodes is ObjectArray) {
       objectArray = charCodes;
@@ skipping 357 matching lines @@
     }
     return _concatAll(stringsArray);
   }
 
   static String _concatAll(ObjectArray<String> strings)
       native "Strings_concatAll";
 }
 
 
 class OneByteString extends StringBase implements String {
+  factory OneByteString._uninstantiable() {
+    throw const UnsupportedOperationException(
+        "OneByteString can only be allocated by the VM");
+  }
+
   // Checks for one-byte whitespaces only.
   // TODO(srdjan): Investigate if 0x85 (NEL) and 0xA0 (NBSP) are valid
   // whitespaces for one byte strings.
   bool _isWhitespace(int codePoint) {
     return
       (codePoint === 32) || // Space.
       ((9 <= codePoint) && (codePoint <= 13)); // CR, LF, TAB, etc.
   }
 
 }
 
 
 class TwoByteString extends StringBase implements String {
+  factory TwoByteString._uninstantiable() {
+    throw const UnsupportedOperationException(
+        "TwoByteString can only be allocated by the VM");
+  }
+  
   // Checks for one-byte whitespaces only.
   // TODO(srdjan): Investigate if 0x85 (NEL) and 0xA0 (NBSP) are valid
   // whitespaces. Add checking for multi-byte whitespace codepoints.
   bool _isWhitespace(int codePoint) {
     return
       (codePoint === 32) || // Space.
       ((9 <= codePoint) && (codePoint <= 13)); // CR, LF, TAB, etc.
   }
 }
 
 
 class FourByteString extends StringBase implements String {
+  factory FourByteString._uninstantiable() {
+    throw const UnsupportedOperationException(
+        "FourByteString can only be allocated by the VM");
+  }
+  
   // Checks for one-byte whitespaces only.
   // TODO(srdjan): Investigate if 0x85 (NEL) and 0xA0 (NBSP) are valid
   // whitespaces. Add checking for multi-byte whitespace codepoints.
   bool _isWhitespace(int codePoint) {
     return
       (codePoint === 32) || // Space.
       ((9 <= codePoint) && (codePoint <= 13)); // CR, LF, TAB, etc.
   }
 }
 
 
 class ExternalOneByteString extends StringBase implements String {
+  factory ExternalOneByteString._uninstantiable() {
+    throw const UnsupportedOperationException(
+        "ExternalOneByteString can only be allocated by the VM");
+  }
+  
   // Checks for one-byte whitespaces only.
   // TODO(srdjan): Investigate if 0x85 (NEL) and 0xA0 (NBSP) are valid
   // whitespaces for one byte strings.
   bool _isWhitespace(int codePoint) {
     return
       (codePoint === 32) || // Space.
       ((9 <= codePoint) && (codePoint <= 13)); // CR, LF, TAB, etc.
   }
 }
 
 
 class ExternalTwoByteString extends StringBase implements String {
+  factory ExternalTwoByteString._uninstantiable() {
+    throw const UnsupportedOperationException(
+        "ExternalTwoByteString can only be allocated by the VM");
+  }
+  
   // Checks for one-byte whitespaces only.
   // TODO(srdjan): Investigate if 0x85 (NEL) and 0xA0 (NBSP) are valid
   // whitespaces. Add checking for multi-byte whitespace codepoints.
   bool _isWhitespace(int codePoint) {
     return
       (codePoint === 32) || // Space.
       ((9 <= codePoint) && (codePoint <= 13)); // CR, LF, TAB, etc.
   }
 }
 
 
 class ExternalFourByteString extends StringBase implements String {
+  factory ExternalFourByteString._uninstantiable() {
+    throw const UnsupportedOperationException(
+        "ExternalFourByteString can only be allocated by the VM");
+  }
+  
   // Checks for one-byte whitespaces only.
   // TODO(srdjan): Investigate if 0x85 (NEL) and 0xA0 (NBSP) are valid
   // whitespaces. Add checking for multi-byte whitespace codepoints.
   bool _isWhitespace(int codePoint) {
     return
       (codePoint === 32) || // Space.
       ((9 <= codePoint) && (codePoint <= 13)); // CR, LF, TAB, etc.
   }
 }
 
@@ skipping 20 matching lines @@
     for (int g in groups) {
       result.add(group(g));
     }
     return result;
   }
 
   final int _start;
   final String str;
   final String pattern;
 }