Fix bug 557: Disallow user side allocation of ImmutableArray. Also added "instantiation-checks" f...

runtime/lib/array.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class ListFactory {
 
   factory List<T>.from(Iterable<T> other) {
     GrowableObjectArray<T> list = new GrowableObjectArray<T>();
     for (final e in other) {
       list.add(e);
@@ skipping 143 matching lines @@
 
 // This is essentially the same class as ObjectArray, but it does not
 // permit any modification of array elements from Dart code. We use
 // this class for arrays constructed from Dart array literals.
 // TODO(hausner): We should consider the trade-offs between two
 // classes (and inline cache misses) versus a field in the native
 // implementation (checks when modifying). We should keep watching
 // the inline cache misses.
 class ImmutableArray<T> implements List<T> {
 
+  factory ImmutableArray._uninstantiable() {
+    throw const UnsupportedOperationException(
+        "ImmutableArray can only be allocated by the VM");
+  }
+
   T operator [](int index) native "ObjectArray_getIndexed";
 
   void operator []=(int index, T value) {
     throw const UnsupportedOperationException(
         "Cannot modify an immutable array");
   }
 
   int get length() native "ObjectArray_getLength";
 
   void copyFrom(List src, int srcStart, int dstStart, int count) {
@@ skipping 121 matching lines @@
     if (!hasNext()) {
       throw const NoMoreElementsException();
     }
     return _array[_pos++];
   }
 
   final List<T> _array;
   final int _length;  // Cache array length for faster access.
   int _pos;
 }