Issue 8619008: Initializing formals can't be optional parameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8619008: Initializing formals can't be optional parameters (Closed)

Created:
9 years, 1 month ago by hausner

Modified:
9 years, 1 month ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Initializing formals can't be optional parameters Add new error message to VM compiler. Remove all optional initializing formals from library and tests. Committed: https://code.google.com/p/dart/source/detail?r=1755

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -23 lines)			Patch
M	corelib/src/exceptions.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	corelib/src/implementation/exceptions.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/file.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/input_stream.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/process.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/bin/socket.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/bin/string_stream.dart	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	1 chunk	+4 lines, -0 lines	1 comment	Download
M	samples/chat/chat_server_lib.dart	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	tests/language/src/TryCatch3Test.dart	View	1	1 chunk	+7 lines, -6 lines	0 comments	Download
M	tools/testing/dart/test_runner.dart	View	1	6 chunks	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

9 years, 1 month ago (2011-11-22 19:58:38 UTC) #3

LGTM. Thanks for the quick turnaround.

-Ivan

http://codereview.chromium.org/8619008/diff/3001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/8619008/diff/3001/runtime/vm/parser.cc#newcode843
runtime/vm/parser.cc:843: if (params->has_named_optional_parameters) {
A comment explaining how this works would be nice, but I guess when you read the
whole thing you do not have it as much out of context.

Expand Messages | Collapse Messages