Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 8619008: Initializing formals can't be optional parameters (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/parser.cc ('K') | « tests/language/src/TryCatch3Test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart (revision 1754)
+++ tools/testing/dart/test_runner.dart (working copy)
@@ -35,7 +35,8 @@
this.timeout,
this.completedHandler,
this.expectedOutcomes,
- [this.isNegative = false]) {
+ [isNegative = false])
+ : this.isNegative = isNegative {
if (!isNegative) {
isNegative = displayName.contains("NegativeTest");
}
@@ -45,7 +46,7 @@
}
}
- void completed() { completedHandler(this); }
+ void completed() { completedHandler(this); }
}
@@ -58,7 +59,7 @@
List<String> stdout;
List<String> stderr;
Duration time;
-
+
TestOutput(this.testCase, this.exitCode, this.timedOut, this.stdout,
this.stderr, this.time) {
testCase.output = this;
@@ -68,7 +69,7 @@
hasCrashed ? CRASH : (hasTimedOut ? TIMEOUT : (hasFailed ? FAIL : PASS));
bool get unexpectedOutput() => !testCase.expectedOutcomes.contains(result);
-
+
// The Java dartc runner exits with code 253 in case of unhandles
// exceptions.
// The VM uses std::abort to terminate on asserts.
@@ -108,7 +109,8 @@
List<String> stderr;
List<Function> handlers;
- RunningProcess(this.testCase, [this.timeout = NO_TIMEOUT]);
+ RunningProcess(this.testCase, [timeout = NO_TIMEOUT])
+ : this.timeout = timeout;
void exitHandler(int exitCode) {
new TestOutput(testCase, exitCode, timedOut, stdout,
@@ -135,7 +137,7 @@
process.exitHandler = exitHandler;
startTime = new Date.now();
process.start();
-
+
InputStream stdoutStream = process.stdout;
InputStream stderrStream = process.stderr;
stdout = new List<String>();
« runtime/vm/parser.cc ('K') | « tests/language/src/TryCatch3Test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698