Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: runtime/vm/parser.cc

Issue 8619008: Initializing formals can't be optional parameters (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/string_stream.dart ('k') | samples/chat/chat_server_lib.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 1754)
+++ runtime/vm/parser.cc (working copy)
@@ -840,6 +840,10 @@
parameter.name_pos = token_index_;
ConsumeToken();
if (parameter.is_field_initializer) {
+ if (params->has_named_optional_parameters) {
Ivan Posva 2011/11/22 19:58:38 A comment explaining how this works would be nice,
+ ErrorMsg(parameter.name_pos,
+ "initializing formal parameter cannot be optional");
+ }
params->has_field_initializer = true;
}
« no previous file with comments | « runtime/bin/string_stream.dart ('k') | samples/chat/chat_server_lib.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698