Test for immutable Lists in ListSet API methods.

Test for immutable Lists in ListSet API methods.

Using the file and socket API it was possible to modify immutable
arrays.

R=sgjesse@google.com,turnidge@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=1604

[Mads Ager (google), 2011-11-16 14:35:13]

Todd, could you check the API side of this?

[turnidge, 2011-11-16 18:50:18]

lgtm, with an optional suggestion below.

http://codereview.chromium.org/8575004/diff/1/runtime/bin/file.cc
File runtime/bin/file.cc (right):

http://codereview.chromium.org/8575004/diff/1/runtime/bin/file.cc#newcode163
runtime/bin/file.cc:163: return_value = total_bytes_read;
There's probably some good diagnostic information for the user in
Dart_GetError(result).  Perhaps not useful in this case though.  Up to you.

http://codereview.chromium.org/8575004/diff/1/runtime/bin/socket.cc
File runtime/bin/socket.cc (right):

http://codereview.chromium.org/8575004/diff/1/runtime/bin/socket.cc#newcode61
runtime/bin/socket.cc:61: if (Dart_IsError(result)) {
Diito previous comment.

http://codereview.chromium.org/8575004/diff/1/runtime/bin/socket_impl.dart
File runtime/bin/socket_impl.dart (right):

http://codereview.chromium.org/8575004/diff/1/runtime/bin/socket_impl.dart#ne...
runtime/bin/socket_impl.dart:301: throw new SocketIOException("Error: readList
failed");
Yeah, here would be a good place to have that error information, perhaps.

[Mads Ager (google), 2011-11-17 06:49:56]

On 2011/11/16 18:50:18, turnidge wrote:
> lgtm, with an optional suggestion below.
> 
> http://codereview.chromium.org/8575004/diff/1/runtime/bin/file.cc
> File runtime/bin/file.cc (right):
> 
> http://codereview.chromium.org/8575004/diff/1/runtime/bin/file.cc#newcode163
> runtime/bin/file.cc:163: return_value = total_bytes_read;
> There's probably some good diagnostic information for the user in
> Dart_GetError(result).  Perhaps not useful in this case though.  Up to you.
> 
> http://codereview.chromium.org/8575004/diff/1/runtime/bin/socket.cc
> File runtime/bin/socket.cc (right):
> 
> http://codereview.chromium.org/8575004/diff/1/runtime/bin/socket.cc#newcode61
> runtime/bin/socket.cc:61: if (Dart_IsError(result)) {
> Diito previous comment.
> 
> http://codereview.chromium.org/8575004/diff/1/runtime/bin/socket_impl.dart
> File runtime/bin/socket_impl.dart (right):
> 
>
http://codereview.chromium.org/8575004/diff/1/runtime/bin/socket_impl.dart#ne...
> runtime/bin/socket_impl.dart:301: throw new SocketIOException("Error: readList
> failed");
> Yeah, here would be a good place to have that error information, perhaps.

I agree. Providing better error messages is on my TODO list in general. I'll put
this back as is for now and work on error messages in a separate change.

Thanks!