Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: runtime/bin/file.cc

Issue 8575004: Test for immutable Lists in ListSet API methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/socket.cc » ('j') | runtime/bin/socket.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/file.cc
diff --git a/runtime/bin/file.cc b/runtime/bin/file.cc
index 58817ea629538ad9744e439ed1897d01e9dfdac5..07201c6e9fdecf669c9657f7134234da7e41132e 100644
--- a/runtime/bin/file.cc
+++ b/runtime/bin/file.cc
@@ -159,8 +159,9 @@ void FUNCTION_NAME(File_ReadList)(Dart_NativeArguments args) {
if (total_bytes_read >= 0) {
result =
Dart_ListSetAsBytes(buffer_obj, offset, buffer, total_bytes_read);
- ASSERT(!Dart_IsError(result));
- return_value = total_bytes_read;
+ if (!Dart_IsError(result)) {
+ return_value = total_bytes_read;
turnidge 2011/11/16 18:50:18 There's probably some good diagnostic information
+ }
}
delete[] buffer;
}
« no previous file with comments | « no previous file | runtime/bin/socket.cc » ('j') | runtime/bin/socket.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698