Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1571)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 8575004: Test for immutable Lists in ListSet API methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/dart_api_impl.cc
diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc
index a0997502203dd42f80b6f8b629de78a6ee726d19..5717ec81b21fca221195dc0b94be6426d557ba4d 100644
--- a/runtime/vm/dart_api_impl.cc
+++ b/runtime/vm/dart_api_impl.cc
@@ -1244,6 +1244,9 @@ DART_EXPORT Dart_Handle Dart_ListSetAsBytes(Dart_Handle list,
DARTSCOPE(isolate);
const Object& obj = Object::Handle(Api::UnwrapHandle(list));
if (obj.IsArray()) {
+ if (obj.IsImmutableArray()) {
+ return Api::Error("Cannot modify immutable array");
+ }
Array& array_obj = Array::Handle();
array_obj ^= obj.raw();
Integer& integer = Integer::Handle();
@@ -1289,6 +1292,9 @@ DART_EXPORT Dart_Handle Dart_ListSetAt(Dart_Handle list,
DARTSCOPE(isolate);
const Object& obj = Object::Handle(Api::UnwrapHandle(list));
if (obj.IsArray()) {
+ if (obj.IsImmutableArray()) {
+ return Api::Error("Cannot modify immutable array");
+ }
Array& array_obj = Array::Handle();
array_obj ^= obj.raw();
const Object& value_obj = Object::Handle(Api::UnwrapHandle(value));

Powered by Google App Engine
This is Rietveld 408576698