Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 8540013: Giving up on the change to report errors with factories and generic types. (Closed)

Created:
9 years, 1 month ago by srdjan
Modified:
9 years, 1 month ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Giving up on the change to report errors with factories and generic types. This means that you will continue to have crashes in Debug mode, but you will be able to "run" in Release mode. Best solution is to get rid of generic types in Link until factories and generic types have been fully implemented. Until then we do not know what can happen when running in release mode. Still trying to figure out how to test frog and leg correctly. Committed: https://code.google.com/p/dart/source/detail?r=1469

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M frog/leg/util/link_implementation.dart View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/parser.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M tests/language/language.status View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
9 years, 1 month ago (2011-11-11 18:40:47 UTC) #1
regis
LGTM http://codereview.chromium.org/8540013/diff/2002/frog/leg/util/link_implementation.dart File frog/leg/util/link_implementation.dart (left): http://codereview.chromium.org/8540013/diff/2002/frog/leg/util/link_implementation.dart#oldcode8 frog/leg/util/link_implementation.dart:8: class LinkFactory<T> { As a temporary workaround, you ...
9 years, 1 month ago (2011-11-11 18:47:13 UTC) #2
srdjan
9 years, 1 month ago (2011-11-11 18:49:19 UTC) #3
http://codereview.chromium.org/8540013/diff/2002/frog/leg/util/link_implement...
File frog/leg/util/link_implementation.dart (left):

http://codereview.chromium.org/8540013/diff/2002/frog/leg/util/link_implement...
frog/leg/util/link_implementation.dart:8: class LinkFactory<T> {
On 2011/11/11 18:47:13, regis wrote:
> As a temporary workaround, you could try to have class LinkFactory<T>
implements
> Link<T> { ... }

I try this next once, I have the build bot green again

http://codereview.chromium.org/8540013/diff/2002/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/8540013/diff/2002/runtime/vm/parser.cc#newcode...
runtime/vm/parser.cc:6392: void Parser::CheckConstructorCallTypeArguments(
On 2011/11/11 18:47:13, regis wrote:
> How about removing this function alltogether? It will not be used once
factories
> are implemented correctly.

I try the fix you suggested (implement) and reenable this if it helps.

Powered by Google App Engine
This is Rietveld 408576698