Giving up on the change to report errors with factories and generic types.

runtime/vm/parser.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/parser.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/compiler_stats.h"
@@ skipping 6371 matching lines @@
     String& errmsg = String::Handle();
     type = ClassFinalizer::FinalizeAndCanonicalizeType(type, &errmsg);
     if (!errmsg.IsNull()) {
       ErrorMsg(errmsg.ToCString());
     }
   }
   return type.raw();
 }
 
 
 void Parser::CheckConstructorCallTypeArguments(

[regis, 2011/11/11 18:47:13]

How about removing this function alltogether? It will not be used once factories
are implemented correctly.

[srdjan, 2011/11/11 18:49:19]

I try the fix you suggested (implement) and reenable this if it helps.

     intptr_t pos, Function& constructor, const TypeArguments& type_arguments) {
   if (!type_arguments.IsNull() &&
       (type_arguments.Length() !=
           Class::Handle(constructor.owner()).NumTypeArguments())) {
-    ErrorMsg(pos, "Incorrect number of type arguments, expected %d got %d",
-        Class::Handle(constructor.owner()).NumTypeArguments(),
-        type_arguments.Length());
+    // TODO(regis): report proper error once we can.
+    // ErrorMsg(pos, "Incorrect number of type arguments, expected %d got %d",
+    //     Class::Handle(constructor.owner()).NumTypeArguments(),
+    //     type_arguments.Length());
   }
 }
 
 
 // Parse "[" [ expr { "," expr } ["," ] "]".
 // Note: if the array literal is empty and the brackets have no whitespace
 // between them, the scanner recognizes the opening and closing bracket
 // as one token of type Token::kINDEX.
 AstNode* Parser::ParseArrayLiteral(intptr_t type_pos,
                                    bool is_const,
@@ skipping 874 matching lines @@
 }
 
 
 void Parser::SkipNestedExpr() {
   const bool saved_mode = SetAllowFunctionLiterals(true);
   SkipExpr();
   SetAllowFunctionLiterals(saved_mode);
 }
 
 }  // namespace dart