runtime/vm/parser.cc - Issue 8540013: Giving up on the change to report errors with factories and generic types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser.cc

Issue 8540013: Giving up on the change to report errors with factories and generic types. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: '' Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/parser.cc

===================================================================

--- runtime/vm/parser.cc (revision 1464)

+++ runtime/vm/parser.cc (working copy)

@@ -6394,9 +6394,10 @@

if (!type_arguments.IsNull() &&

(type_arguments.Length() !=

Class::Handle(constructor.owner()).NumTypeArguments())) {

- ErrorMsg(pos, "Incorrect number of type arguments, expected %d got %d",

- Class::Handle(constructor.owner()).NumTypeArguments(),

- type_arguments.Length());

+ // TODO(regis): report proper error once we can.

+ // ErrorMsg(pos, "Incorrect number of type arguments, expected %d got %d",

+ // Class::Handle(constructor.owner()).NumTypeArguments(),

+ // type_arguments.Length());

}

« no previous file with comments | « frog/leg/util/link_implementation.dart ('k') | tests/language/language.status » ('j') | no next file with comments »