Issue 8528010: Changes to pass the current isolate to all runtime and native calls.

Issue 8528010: Changes to pass the current isolate to all runtime and native calls. (Closed)

Created:
9 years, 1 month ago by siva

Modified:
9 years, 1 month ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Changes to pass the current isolate to all runtime and native calls. Committed: https://code.google.com/p/dart/source/detail?r=1499

Patch Set 3 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+283 lines, -319 lines)			Patch
M	runtime/lib/isolate.cc	View	1 2	4 chunks	+9 lines, -8 lines	0 comments	Download
M	runtime/vm/allocation.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/allocation.cc	View	1 2	1 chunk	+5 lines, -6 lines	0 comments	Download
M	runtime/vm/allocation_test.cc	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1 2	10 chunks	+18 lines, -15 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/dart.cc	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/dart_api_impl.h	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 2	80 chunks	+135 lines, -194 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 2	10 chunks	+10 lines, -20 lines	0 comments	Download
M	runtime/vm/dart_api_state.h	View	1 2	3 chunks	+3 lines, -6 lines	0 comments	Download
M	runtime/vm/handles.h	View	1 2	9 chunks	+11 lines, -9 lines	0 comments	Download
M	runtime/vm/handles.cc	View	1 2	2 chunks	+7 lines, -7 lines	0 comments	Download
M	runtime/vm/handles_test.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/heap.h	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/heap.cc	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1 2	2 chunks	+6 lines, -4 lines	0 comments	Download
M	runtime/vm/native_arguments.h	View	1 2	4 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/native_entry.h	View	1 2	2 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/raw_object.cc	View	1 2	3 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/runtime_entry.h	View	1 2	1 chunk	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/scavenger.h	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	runtime/vm/scavenger.cc	View	1 2	3 chunks	+7 lines, -5 lines	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	1 2	2 chunks	+6 lines, -4 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2	4 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/thread.h	View	1 2	3 chunks	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/unit_test.h	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/zone.h	View	1 2	2 chunks	+1 line, -3 lines	0 comments	Download
M	runtime/vm/zone.cc	View	1 2	1 chunk	+5 lines, -4 lines	0 comments	Download
M	runtime/vm/zone_test.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTMwC -ip http://codereview.chromium.org/8528010/diff/7005/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): http://codereview.chromium.org/8528010/diff/7005/runtime/vm/code_generator.cc#newcode799 runtime/vm/code_generator.cc:799: Isolate* isolate = arguments.isolate(); This is such ...

9 years, 1 month ago (2011-11-11 22:07:07 UTC) #2

siva

9 years, 1 month ago (2011-11-12 03:01:05 UTC) #3

http://codereview.chromium.org/8528010/diff/7005/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

http://codereview.chromium.org/8528010/diff/7005/runtime/vm/code_generator.cc...
runtime/vm/code_generator.cc:799: Isolate* isolate = arguments.isolate();
On 2011/11/11 22:07:07, Ivan Posva wrote:
> This is such a repeating pattern that we might consider passing it as a
> parameter into these functions.

Done.

http://codereview.chromium.org/8528010/diff/7005/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8528010/diff/7005/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:395: DARTSCOPE(isolate);
On 2011/11/11 22:07:07, Ivan Posva wrote:
> How about changing this to:
> DARTSCOPE(Isolate::Current());
> 
> It is such a repeating pattern.

Done.

http://codereview.chromium.org/8528010/diff/7005/runtime/vm/native_entry.h
File runtime/vm/native_entry.h (right):

http://codereview.chromium.org/8528010/diff/7005/runtime/vm/native_entry.h#ne...
runtime/vm/native_entry.h:45: DN_Helper##name(arguments);                       
                      \
On 2011/11/11 22:07:07, Ivan Posva wrote:
> DN_Helper##name(arguments->isolate(), arguments);

Done.

http://codereview.chromium.org/8528010/diff/7005/runtime/vm/native_entry.h#ne...
runtime/vm/native_entry.h:49: static void DN_Helper##name(NativeArguments*
arguments)
On 2011/11/11 22:07:07, Ivan Posva wrote:
> DN_Helper##name(Isolate* isolate, NativeArguments* arguments)

Done.

http://codereview.chromium.org/8528010/diff/7005/runtime/vm/runtime_entry.h
File runtime/vm/runtime_entry.h (right):

http://codereview.chromium.org/8528010/diff/7005/runtime/vm/runtime_entry.h#n...
runtime/vm/runtime_entry.h:67: static void DRT_Helper##name(NativeArguments
arguments)
On 2011/11/11 22:07:07, Ivan Posva wrote:
> ditto

Done.

Expand Messages | Collapse Messages