Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: runtime/vm/scavenger.cc

Issue 8528010: Changes to pass the current isolate to all runtime and native calls. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/scavenger.h ('k') | runtime/vm/snapshot_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/scavenger.cc
===================================================================
--- runtime/vm/scavenger.cc (revision 1496)
+++ runtime/vm/scavenger.cc (working copy)
@@ -5,6 +5,7 @@
#include "vm/scavenger.h"
#include "vm/dart.h"
+#include "vm/isolate.h"
#include "vm/object.h"
#include "vm/stack_frame.h"
#include "vm/verifier.h"
@@ -165,9 +166,9 @@
}
-void Scavenger::IterateRoots(ObjectPointerVisitor* visitor) {
- Isolate::Current()->VisitObjectPointers(
- visitor, StackFrameIterator::kDontValidateFrames);
+void Scavenger::IterateRoots(Isolate* isolate, ObjectPointerVisitor* visitor) {
+ isolate->VisitObjectPointers(visitor,
+ StackFrameIterator::kDontValidateFrames);
heap_->IterateOldPointers(visitor);
}
@@ -195,14 +196,15 @@
// Scavenging is not reentrant. Make sure that is the case.
ASSERT(!scavenging_);
scavenging_ = true;
- NoHandleScope no_handles;
+ Isolate* isolate = Isolate::Current();
+ NoHandleScope no_handles(isolate);
Timer timer(FLAG_verbose_gc, "Scavenge");
timer.Start();
// Setup the visitor and run a scavenge.
ScavengerVisitor visitor(this);
Prologue();
- IterateRoots(&visitor);
+ IterateRoots(isolate, &visitor);
ProcessToSpace(&visitor);
Epilogue();
timer.Stop();
« no previous file with comments | « runtime/vm/scavenger.h ('k') | runtime/vm/snapshot_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698