runtime/vm/native_entry.h - Issue 8528010: Changes to pass the current isolate to all runtime and native calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/native_entry.h

Issue 8528010: Changes to pass the current isolate to all runtime and native calls. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: '' Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/native_entry.h

===================================================================

--- runtime/vm/native_entry.h (revision 1496)

+++ runtime/vm/native_entry.h (working copy)

@@ -32,7 +32,7 @@

#define DEFINE_NATIVE_ENTRY(name, argument_count) \

- static void DN_Helper##name(NativeArguments* arguments); \

+ static void DN_Helper##name(Isolate* isolate, NativeArguments* arguments); \

void NATIVE_ENTRY_FUNCTION(name)(Dart_NativeArguments args) { \

CHECK_STACK_ALIGNMENT; \

VERIFY_ON_TRANSITION; \

@@ -40,13 +40,13 @@

ASSERT(arguments->Count() == argument_count); \

if (FLAG_trace_natives) OS::Print("Calling native: %s\n", ""#name); \

{ \

- Zone zone; \

- HANDLESCOPE(); \

- DN_Helper##name(arguments); \

+ Zone zone(arguments->isolate()); \

+ HANDLESCOPE(arguments->isolate()); \

+ DN_Helper##name(arguments->isolate(), arguments); \

} \

VERIFY_ON_TRANSITION; \

} \

- static void DN_Helper##name(NativeArguments* arguments)

+ static void DN_Helper##name(Isolate* isolate, NativeArguments* arguments)

#define DECLARE_NATIVE_ENTRY(name, argument_count) \

« no previous file with comments | « runtime/vm/native_arguments.h ('k') | runtime/vm/raw_object.cc » ('j') | no next file with comments »