Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 8476002: Fix more co19 crashes. Introduce GET_NATIVE_ARGUMENT that throws an illegal argument exception if... (Closed)

Created:
9 years, 1 month ago by srdjan
Modified:
9 years, 1 month ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix more co19 crashes. Introduce GET_NATIVE_ARGUMENT that throws an illegal argument exception if the native argument is of incorrect type. Committed: https://code.google.com/p/dart/source/detail?r=1205

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -34 lines) Patch
M runtime/lib/error.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/lib/integers.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/lib/object.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/lib/string.cc View 2 chunks +3 lines, -25 lines 0 comments Download
M runtime/vm/native_entry.h View 1 chunk +15 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
srdjan
9 years, 1 month ago (2011-11-04 16:01:11 UTC) #1
hausner
9 years, 1 month ago (2011-11-04 16:23:54 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698