Fix more co19 crashes. Introduce GET_NATIVE_ARGUMENT that throws an illegal argument exception if...

runtime/lib/string.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "vm/exceptions.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 
@@ skipping 78 matching lines @@
     GrowableArray<const Object*> arguments;
     arguments.Add(&index);
     Exceptions::ThrowByType(Exceptions::kIndexOutOfRange, arguments);
     return 0;
   }
 }
 
 
 DEFINE_NATIVE_ENTRY(String_charAt, 2) {
   const String& str = String::CheckedHandle(arguments->At(0));
-  const Instance& index_instance = Instance::CheckedHandle(arguments->At(1));
-  if (!index_instance.IsInteger()) {
-    GrowableArray<const Object*> args;
-    args.Add(&index_instance);
-    Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
-  }
-  Integer& index = Integer::Handle();
-  index ^= index_instance.raw();
+  GET_NATIVE_ARGUMENT(Integer, index, arguments->At(1));
   uint32_t value = StringValueAt(str, index);
   ASSERT(value <= 0x10FFFF);
   arguments->SetReturn(String::Handle(String::NewSymbol(&value, 1)));
 }
 
-
 DEFINE_NATIVE_ENTRY(String_charCodeAt, 2) {
   const String& str = String::CheckedHandle(arguments->At(0));
-  const Integer& index_instance = Integer::CheckedHandle(arguments->At(1));
-  if (!index_instance.IsInteger()) {
-    GrowableArray<const Object*> args;
-    args.Add(&index_instance);
-    Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
-  }
-  Integer& index = Integer::Handle();
-  index ^= index_instance.raw();
+  GET_NATIVE_ARGUMENT(Integer, index, arguments->At(1));
   int32_t value = StringValueAt(str, index);
   ASSERT(value >= 0);
   ASSERT(value <= 0x10FFFF);
   arguments->SetReturn(Smi::Handle(Smi::New(value)));
 }
 
 
 DEFINE_NATIVE_ENTRY(String_concat, 2) {
   const String& a = String::CheckedHandle(arguments->At(0));
-  ASSERT(!a.IsNull());  // The receiver cannot be null.
-  const Instance& b_instance = Instance::CheckedHandle(arguments->At(1));
-  if (!b_instance.IsString()) {
-    GrowableArray<const Object*> args;
-    Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
-  }
-  String& b = String::Handle();
-  b  ^= b_instance.raw();
+  GET_NATIVE_ARGUMENT(String, b, arguments->At(1));
   const String& result = String::Handle(String::Concat(a, b));
   arguments->SetReturn(result);
 }
 
 
 DEFINE_NATIVE_ENTRY(String_toLowerCase, 1) {
   const String& str = String::CheckedHandle(arguments->At(0));
   ASSERT(!str.IsNull());
   const String& result = String::Handle(String::ToLowerCase(str));
   arguments->SetReturn(result);
@@ skipping 23 matching lines @@
       GrowableArray<const Object*> args;
       args.Add(&elem);
       Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
     }
   }
   const String& result = String::Handle(String::ConcatAll(strings));
   arguments->SetReturn(result);
 }
 
 }  // namespace dart