runtime/lib/object.cc - Issue 8476002: Fix more co19 crashes. Introduce GET_NATIVE_ARGUMENT that throws an illegal argument exception if...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/object.cc

Issue 8476002: Fix more co19 crashes. Introduce GET_NATIVE_ARGUMENT that throws an illegal argument exception if... (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/object.cc

===================================================================

--- runtime/lib/object.cc (revision 1200)

+++ runtime/lib/object.cc (working copy)

@@ -19,12 +19,12 @@

DEFINE_NATIVE_ENTRY(Object_noSuchMethod, 3) {

const Instance& instance = Instance::CheckedHandle(arguments->At(0));

- const String& function_name = String::CheckedHandle(arguments->At(1));

- const Array& func_args = Array::CheckedHandle(arguments->At(2));

if (instance.IsNull()) {

GrowableArray<const Object*> args;

Exceptions::ThrowByType(Exceptions::kNullPointer, args);

}

+ GET_NATIVE_ARGUMENT(String, function_name, arguments->At(1));

+ GET_NATIVE_ARGUMENT(Array, func_args, arguments->At(2));

GrowableArray<const Object*> dart_arguments(3);

dart_arguments.Add(&instance);

dart_arguments.Add(&function_name);

« no previous file with comments | « runtime/lib/integers.cc ('k') | runtime/lib/string.cc » ('j') | no next file with comments »