Add optional arguments to our indexOf/lastIndexOf methods.

Add optional arguments to our indexOf/lastIndexOf methods.
Committed: https://code.google.com/p/dart/source/detail?r=947

[kasperl, 2011-10-31 12:35:09]

Quick nit:

http://codereview.chromium.org/8424012/diff/3001/client/dom/generated/src/wra...
File
client/dom/generated/src/wrapping/_CanvasPixelArrayWrappingImplementation.dart
(right):

http://codereview.chromium.org/8424012/diff/3001/client/dom/generated/src/wra...
client/dom/generated/src/wrapping/_CanvasPixelArrayWrappingImplementation.dart:49:
int lastIndexOf(int element, [int fromIndex = null]) {
Why is this called fromIndex in lastIndexOf and startIndex in indexOf? I think
these names need to match to make it less surprising to use. I wonder if the
name needs to contain the word index since it's nicely encapsulated in the name
of the method too.

[floitsch, 2011-10-31 12:52:57]

LGTM, but I agree with Kasper: the named arguments should be consistent. Maybe
just 'start' ?

[ngeoffray, 2011-10-31 13:19:23]

Thanks for the reviews. I have dropped the "Index" in the argument name, and
name the argument to [start] for both methods.

[srdjan, 2011-10-31 18:01:29]

http://codereview.chromium.org/8424012/diff/1002/client/html/generated/src/wr...
File
client/html/generated/src/wrapping/_StyleSheetListWrappingImplementation.dart
(right):

http://codereview.chromium.org/8424012/diff/1002/client/html/generated/src/wr...
client/html/generated/src/wrapping/_StyleSheetListWrappingImplementation.dart:45:
if (start == null) start = length - 1;
===

http://codereview.chromium.org/8424012/diff/1002/client/html/src/DocumentFrag...
File client/html/src/DocumentFragmentWrappingImplementation.dart (right):

http://codereview.chromium.org/8424012/diff/1002/client/html/src/DocumentFrag...
client/html/src/DocumentFragmentWrappingImplementation.dart:105: int
lastIndexOf(Element element, [int start = null]) {
WHy not just [int start] (here and everywhere else where default value is null)?

[ngeoffray, 2011-11-01 07:50:43]

Thanks Srdjan,

http://codereview.chromium.org/8424012/diff/1002/client/html/generated/src/wr...
File
client/html/generated/src/wrapping/_StyleSheetListWrappingImplementation.dart
(right):

http://codereview.chromium.org/8424012/diff/1002/client/html/generated/src/wr...
client/html/generated/src/wrapping/_StyleSheetListWrappingImplementation.dart:45:
if (start == null) start = length - 1;
On 2011/10/31 18:01:29, srdjan wrote:
> ===

Nice catch. I will let Jacob's script handle this case (I didn't know how to
generate the files, so I manually edited them).

http://codereview.chromium.org/8424012/diff/1002/client/html/src/DocumentFrag...
File client/html/src/DocumentFragmentWrappingImplementation.dart (right):

http://codereview.chromium.org/8424012/diff/1002/client/html/src/DocumentFrag...
client/html/src/DocumentFragmentWrappingImplementation.dart:105: int
lastIndexOf(Element element, [int start = null]) {
On 2011/10/31 18:01:29, srdjan wrote:
> WHy not just [int start] (here and everywhere else where default value is
null)?

Last time I checked, not giving a default value failed on DartC.