Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: runtime/lib/growable_array.dart

Issue 8424012: Add optional arguments to our indexOf/lastIndexOf methods. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/growable_array.dart
===================================================================
--- runtime/lib/growable_array.dart (revision 942)
+++ runtime/lib/growable_array.dart (working copy)
@@ -75,9 +75,6 @@
// The length of this growable array. It is always less than the
// length of the backing array.
int _length;
- // Constant used by indexOf and lastIndexOf when the element given
- // is not in the array.
- static final int ABSENT = -1;
GrowableObjectArray()
: _length = 0, backingArray = new ObjectArray<T>(4) {}
@@ -172,12 +169,13 @@
return backingArray[_length - 1];
}
- int indexOf(T element, int startIndex) {
- return Arrays.indexOf(backingArray, element, startIndex, _length);
+ int indexOf(T element, [int start = 0]) {
+ return Arrays.indexOf(backingArray, element, start, _length);
}
- int lastIndexOf(T element, int startIndex) {
- return Arrays.lastIndexOf(backingArray, element, startIndex);
+ int lastIndexOf(T element, [int start = null]) {
+ if (start === null) start = length - 1;
+ return Arrays.lastIndexOf(backingArray, element, start);
}
/**

Powered by Google App Engine
This is Rietveld 408576698