Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: client/html/src/ElementWrappingImplementation.dart

Issue 8424012: Add optional arguments to our indexOf/lastIndexOf methods. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: client/html/src/ElementWrappingImplementation.dart
===================================================================
--- client/html/src/ElementWrappingImplementation.dart (revision 942)
+++ client/html/src/ElementWrappingImplementation.dart (working copy)
@@ -118,12 +118,13 @@
throw const NotImplementedException();
}
- int indexOf(Element element, int startIndex) {
- return _Lists.indexOf(this, element, startIndex, this.length);
+ int indexOf(Element element, [int start = 0]) {
+ return _Lists.indexOf(this, element, start, this.length);
}
- int lastIndexOf(Element element, int startIndex) {
- return _Lists.lastIndexOf(this, element, startIndex);
+ int lastIndexOf(Element element, [int start = null]) {
+ if (start === null) start = length - 1;
+ return _Lists.lastIndexOf(this, element, start);
}
void clear() {
@@ -230,11 +231,11 @@
throw const NotImplementedException();
}
- int indexOf(Element element, int startIndex) {
+ int indexOf(Element element, [int start = 0]) {
throw 'Not impl yet. todo(jacobr)';
}
- int lastIndexOf(Element element, int startIndex) {
+ int lastIndexOf(Element element, [int start = null]) {
throw 'Not impl yet. todo(jacobr)';
}

Powered by Google App Engine
This is Rietveld 408576698